Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: table selection checkbox or radio should be rendered even if invisible #32846

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: table selection checkbox or radio should be rendered even if invisible #32846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b231aca
fix: table selection checkbox or radio should be rendered even if inv…
smhigley Sep 16, 2024
7f51879
change file
smhigley Sep 16, 2024
9058297
remove unrelated fix
smhigley Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-table-a47e4abb-986f-4876-8f3b-1d94487949f6.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
smhigley marked this conversation as resolved.
Show resolved Hide resolved
"type": "patch",
"comment": "fix: table selection checkbox or radio should be rendered even if invisible",
"packageName": "@fluentui/react-table",
"email": "sarah.higley@microsoft.com",
"dependentChangeType": "patch"
}
4 changes: 2 additions & 2 deletions ...omponents/react-table/library/src/components/TableSelectionCell/useTableSelectionCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ export const useTableSelectionCell_unstable = (
radioIndicator: Radio,
},
checkboxIndicator: slot.optional(props.checkboxIndicator, {
renderByDefault: type === 'checkbox' && !invisible,
renderByDefault: type === 'checkbox',
defaultProps: { checked: props.checked },
elementType: Checkbox,
}),
radioIndicator: slot.optional(props.radioIndicator, {
renderByDefault: type === 'radio' && !invisible,
renderByDefault: type === 'radio',
defaultProps: { checked: !!checked, input: { name: useId('table-selection-radio') } },
elementType: Radio,
}),
Expand Down
Loading