Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web-components): add Tooltip component #32852

Merged
merged 16 commits into from
Nov 4, 2024
Merged

feat(web-components): add Tooltip component #32852

merged 16 commits into from
Nov 4, 2024

Conversation

davatron5000
Copy link
Contributor

Previous Behavior

  • No Tooltip component

New Behavior

  • Add Tooltip component
    • Follows the React positioning shorthands
    • Does not currently implement the arrow functionality due to a Shadow DOM limitation with CSS anchor position.

Note

Needs feedback! Tooltip requires CSS anchor position polyfill for older browsers but polyfill is still in-progress.

Related Issue(s)

@davatron5000 davatron5000 requested a review from a team as a code owner September 17, 2024 17:27
@fabricteam
Copy link
Collaborator

fabricteam commented Sep 17, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

marchbox
marchbox reviewed Sep 26, 2024
View reviewed changes
packages/web-components/.storybook/preview-head.html Outdated Show resolved Hide resolved
packages/web-components/src/tooltip/tooltip.ts Outdated Show resolved Hide resolved
packages/web-components/src/tooltip/tooltip.ts Outdated Show resolved Hide resolved
packages/web-components/src/tooltip/tooltip.ts Outdated Show resolved Hide resolved
radium-v
radium-v reviewed Sep 26, 2024
View reviewed changes
packages/web-components/src/tooltip/tooltip.ts Outdated Show resolved Hide resolved
packages/web-components/src/tooltip/tooltip.ts Outdated Show resolved Hide resolved
packages/web-components/src/tooltip/tooltip.ts Outdated Show resolved Hide resolved
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 30, 2024 •
edited
Loading

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@radium-v radium-v self-requested a review October 31, 2024 14:51
@davatron5000 davatron5000 merged commit 70d3d23 into microsoft:master Nov 4, 2024
16 checks passed
@davatron5000 davatron5000 deleted the feat/tooltip branch November 4, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@chrisdholt chrisdholt chrisdholt left review comments

@marchbox marchbox marchbox left review comments

@eljefe223 eljefe223 eljefe223 approved these changes

@mlijanto mlijanto mlijanto approved these changes

@radium-v radium-v Awaiting requested review from radium-v

Assignees
No one assigned
Labels
Component: Tooltip web-components
Projects
@fluentui Web Components
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component: Tooltip
7 participants
@davatron5000 @fabricteam @mlijanto @marchbox @radium-v @chrisdholt @eljefe223