Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to ts 5.2.2 #32859

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

chore: migrate to ts 5.2.2 #32859

wants to merge 8 commits into from
+353 −59

Conversation

mainframev
Copy link
Contributor

Previous Behavior

New Behavior

Related Issue(s)

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 18, 2024 •
edited
Loading

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 18, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 18, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 647 634 5000
Button mount 306 312 5000
Field mount 1168 1158 5000
FluentProvider mount 716 722 5000
FluentProviderWithTheme mount 83 83 10
FluentProviderWithTheme virtual-rerender 37 38 10
FluentProviderWithTheme virtual-rerender-with-unmount 89 78 10
MakeStyles mount 914 904 50000
Persona mount 1766 1696 5000
SpinButton mount 1399 1424 5000
SwatchPicker mount 1646 1643 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 18, 2024 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react
Announced		 38.48 kB
13.282 kB		 38.476 kB
13.282 kB		 -4 B
react
Autofill		 15.428 kB
4.768 kB		 15.42 kB
4.766 kB		 -8 B
-2 B
react
Breadcrumb		 202.185 kB
60.419 kB		 202.087 kB
60.333 kB		 -98 B
-86 B
react
Button		 195.64 kB
56.642 kB		 195.563 kB
56.577 kB		 -77 B
-65 B
react
ButtonGrid		 180.571 kB
54.626 kB		 180.508 kB
54.583 kB		 -63 B
-43 B
react
Calendar		 121.763 kB
37.01 kB		 121.74 kB
36.995 kB		 -23 B
-15 B
react
ColorPicker		 135.222 kB
42.228 kB		 135.155 kB
42.174 kB		 -67 B
-54 B
react
ComboBox		 252.077 kB
72.336 kB		 251.975 kB
72.241 kB		 -102 B
-95 B
react
CommandBar		 203.226 kB
60.147 kB		 203.128 kB
60.069 kB		 -98 B
-78 B
react
ContextualMenu		 155.108 kB
48.186 kB		 155.085 kB
48.172 kB		 -23 B
-14 B
react
DatePicker		 184.185 kB
56.175 kB		 184.136 kB
56.136 kB		 -49 B
-39 B
react
DetailsList		 229.966 kB
65.926 kB		 229.772 kB
65.763 kB		 -194 B
-163 B
react
Dialog		 211.492 kB
63.169 kB		 211.415 kB
63.098 kB		 -77 B
-71 B
react
DocumentCard		 217.178 kB
64.45 kB		 217.105 kB
64.373 kB		 -73 B
-77 B
react
DraggableZone		 34.305 kB
11.509 kB		 34.303 kB
11.511 kB		 -2 B
2 B
react
Dropdown		 234.124 kB
68.674 kB		 234.02 kB
68.556 kB		 -104 B
-118 B
react
ExtendedPicker		 96.795 kB
27.893 kB		 96.744 kB
27.862 kB		 -51 B
-31 B
react
Facepile		 210.78 kB
63.193 kB		 210.682 kB
63.116 kB		 -98 B
-77 B
react
FloatingPicker		 242.221 kB
69.023 kB		 242.137 kB
68.938 kB		 -84 B
-85 B
react
FocusZone		 55.053 kB
17.47 kB		 55.03 kB
17.46 kB		 -23 B
-10 B
react
Grid		 180.571 kB
54.626 kB		 180.508 kB
54.583 kB		 -63 B
-43 B
react
GroupedList		 135.03 kB
40.749 kB		 134.926 kB
40.659 kB		 -104 B
-90 B
react
GroupedListV2		 122.619 kB
37.852 kB		 122.543 kB
37.766 kB		 -76 B
-86 B
react
HoverCard		 97.16 kB
30.816 kB		 97.148 kB
30.79 kB		 -12 B
-26 B
react
KeytipLayer		 103.459 kB
32.014 kB		 103.455 kB
32.012 kB		 -4 B
-2 B
react
Keytips		 106.227 kB
33.014 kB		 106.223 kB
33.014 kB		 -4 B
react
List		 39.4 kB
12.481 kB		 39.371 kB
12.463 kB		 -29 B
-18 B
react
MarqueeSelection		 74.528 kB
22.424 kB		 74.504 kB
22.417 kB		 -24 B
-7 B
react
MessageBar		 190.675 kB
57.075 kB		 190.612 kB
57.029 kB		 -63 B
-46 B
react
Modal		 93.657 kB
30.253 kB		 93.655 kB
30.255 kB		 -2 B
2 B
react
Nav		 188.175 kB
56.524 kB		 188.09 kB
56.448 kB		 -85 B
-76 B
react
Panel		 201.233 kB
60.035 kB		 201.131 kB
59.937 kB		 -102 B
-98 B
react
Persona		 114.83 kB
36.503 kB		 114.811 kB
36.488 kB		 -19 B
-15 B
react
PersonaCoin		 114.83 kB
36.503 kB		 114.811 kB
36.488 kB		 -19 B
-15 B
react
Pickers		 294.244 kB
82.438 kB		 294.11 kB
82.299 kB		 -134 B
-139 B
react
Pivot		 189.068 kB
57.252 kB		 189.005 kB
57.205 kB		 -63 B
-47 B
react
ProgressIndicator		 39.491 kB
13.54 kB		 39.481 kB
13.536 kB		 -10 B
-4 B
react
Rating		 81.995 kB
26.107 kB		 81.972 kB
26.089 kB		 -23 B
-18 B
react
Fluent UI React (entire library)		 1.014 MB
281.935 kB		 1.014 MB
281.48 kB		 -542 B
-455 B
react
ScrollablePane		 55.551 kB
17.729 kB		 55.545 kB
17.723 kB		 -6 B
-6 B
react
SearchBox		 188.95 kB
56.685 kB		 188.887 kB
56.63 kB		 -63 B
-55 B
react
SelectedItemsList		 232.732 kB
67.931 kB		 232.65 kB
67.848 kB		 -82 B
-83 B
react
Selection		 42.464 kB
12.301 kB		 42.444 kB
12.278 kB		 -20 B
-23 B
react
ShimmeredDetailsList		 240.748 kB
68.656 kB		 240.554 kB
68.492 kB		 -194 B
-164 B
react
SpinButton		 192.651 kB
57.78 kB		 192.588 kB
57.723 kB		 -63 B
-57 B
react
Spinner		 41.764 kB
14.469 kB		 41.762 kB
14.471 kB		 -2 B
2 B
react
Sticky		 32.613 kB
10.509 kB		 32.599 kB
10.504 kB		 -14 B
-5 B
react
SwatchColorPicker		 190.896 kB
58.128 kB		 190.833 kB
58.08 kB		 -63 B
-48 B
react
TeachingBubble		 205.952 kB
61.057 kB		 205.885 kB
61.012 kB		 -67 B
-45 B
react
TextField		 80.792 kB
25.333 kB		 80.766 kB
25.313 kB		 -26 B
-20 B
react
TimePicker		 241.859 kB
70.092 kB		 241.786 kB
70.008 kB		 -73 B
-84 B
react
Tooltip		 87.324 kB
28.217 kB		 87.305 kB
28.21 kB		 -19 B
-7 B
react
WeeklyDayPicker		 101.917 kB
31.829 kB		 101.884 kB
31.813 kB		 -33 B
-16 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 510 B
328 B
global-context
createContextSelector		 537 B
339 B
keyboard-key
keyboard-key package		 3.746 kB
1.928 kB
priority-overflow
createOverflowManager		 4.457 kB
1.856 kB
react
ActivityItem		 71.224 kB
23.353 kB
react
Callout		 84.292 kB
27.63 kB
react
Check		 53.185 kB
17.843 kB
react
Checkbox		 59.971 kB
19.889 kB
react
ChoiceGroup		 65.48 kB
21.488 kB
react
ChoiceGroupOption		 58.748 kB
19.364 kB
react
Coachmark		 93.132 kB
29.416 kB
react
Color		 7.789 kB
3.127 kB
react
DateTimeUtilities		 5.244 kB
1.849 kB
react
Divider		 19.591 kB
6.841 kB
react
DragDrop		 8.343 kB
2.724 kB
react
Fabric		 41.732 kB
14.349 kB
react
FocusTrapZone		 17.03 kB
5.924 kB
react
Icon		 51.873 kB
17.266 kB
react
Icons		 66.361 kB
24.397 kB
react
Image		 46.887 kB
15.703 kB
react
Keytip		 81.661 kB
26.758 kB
react
KeytipData		 14.028 kB
4.587 kB
react
Label		 38.335 kB
13.251 kB
react
Layer		 48.084 kB
16.358 kB
react
Link		 39.668 kB
13.662 kB
react
OverflowSet		 33.376 kB
11.317 kB
react
Overlay		 40.889 kB
14.084 kB
react
PersonaPresence		 58.055 kB
19.378 kB
react
Popup		 12.294 kB
4.195 kB
react
Positioning		 22.807 kB
7.701 kB
react
PositioningContainer		 73.838 kB
23.759 kB
react
ResizeGroup		 13.338 kB
4.377 kB
react
ResponsiveMode		 8.13 kB
2.966 kB
react
SelectableOption		 724 B
413 B
react
Separator		 35.372 kB
12.142 kB
react
Shimmer		 49.238 kB
16.264 kB
react
Slider		 57.639 kB
19.206 kB
react
Stack		 41.734 kB
14.268 kB
react
Styling		 46.033 kB
15.135 kB
react
Text		 36.908 kB
12.822 kB
react
Theme		 43.501 kB
14.183 kB
react
ThemeGenerator		 12.392 kB
4.126 kB
react
Toggle		 46.21 kB
15.966 kB
react
Utilities		 82.675 kB
25.119 kB
react
Viewport		 23.888 kB
7.656 kB
react
WindowProvider		 1.059 kB
541 B
react-accordion
Accordion (including children components)		 104.529 kB
32.097 kB
react-avatar
Avatar		 49.303 kB
15.815 kB
react-avatar
AvatarGroup		 20.106 kB
7.968 kB
react-avatar
AvatarGroupItem		 63.447 kB
20.034 kB
react-badge
Badge		 25.954 kB
8.595 kB
react-badge
CounterBadge		 26.733 kB
8.872 kB
react-badge
PresenceBadge		 25.719 kB
9.457 kB
react-breadcrumb
@fluentui/react-breadcrumb - package		 113.699 kB
31.498 kB
react-button
Button		 37.104 kB
10.766 kB
react-button
CompoundButton		 43.518 kB
12.068 kB
react-button
MenuButton		 41.916 kB
12.119 kB
react-button
SplitButton		 49.933 kB
13.693 kB
react-button
ToggleButton		 53.037 kB
12.528 kB
react-calendar-compat
Calendar Compat		 149.573 kB
39.871 kB
react-card
Card - All		 101.248 kB
28.626 kB
react-card
Card		 94.022 kB
26.806 kB
react-card
CardFooter		 14.355 kB
5.79 kB
react-card
CardHeader		 16.888 kB
6.669 kB
react-card
CardPreview		 14.42 kB
5.922 kB
react-checkbox
Checkbox		 35.118 kB
12.077 kB
react-combobox
Combobox (including child components)		 104.398 kB
34.199 kB
react-combobox
Dropdown (including child components)		 104.984 kB
34.114 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 69.14 kB
20.137 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 218.197 kB
63.203 kB
react-components
react-components: FluentProvider & webLightTheme		 44.447 kB
14.59 kB
react-components
react-components: entire library		 1.1 MB
271.983 kB
react-datepicker-compat
DatePicker Compat		 223.64 kB
63.299 kB
react-dialog
Dialog (including children components)		 99.724 kB
29.912 kB
react-divider
Divider		 21.328 kB
7.953 kB
react-field
Field		 23.384 kB
8.891 kB
react-image
Image		 15.36 kB
6.236 kB
react-input
Input		 28.014 kB
9.444 kB
react-jsx-runtime
Classic Pragma		 1.057 kB
530 B
react-jsx-runtime
JSX Dev Runtime		 3.771 kB
1.643 kB
react-jsx-runtime
JSX Runtime		 4.367 kB
1.874 kB
react-label
Label		 14.671 kB
5.99 kB
react-link
Link		 17.192 kB
6.98 kB
react-list-preview
List		 88.626 kB
26.435 kB
react-list-preview
ListItem		 112.168 kB
33.273 kB
react-menu
Menu (including children components)		 151.856 kB
45.848 kB
react-menu
Menu (including selectable components)		 154.537 kB
46.326 kB
react-message-bar
MessageBar (all components)		 24.722 kB
9.205 kB
react-motion
@fluentui/react-motion - createMotionComponent()		 4.303 kB
1.899 kB
react-motion
@fluentui/react-motion - createPresenceComponent()		 5.038 kB
2.229 kB
react-motion
@fluentui/react-motion - PresenceGroup		 1.714 kB
819 B
react-northstar
Accordion		 85.383 kB
26.519 kB
react-northstar
Alert		 87.438 kB
26.904 kB
react-northstar
Animation		 55.331 kB
17.83 kB
react-northstar
Attachment		 86.832 kB
26.7 kB
react-northstar
Avatar		 80.267 kB
24.633 kB
react-northstar
Box		 75.236 kB
23.812 kB
react-northstar
Breadcrumb		 79.911 kB
24.717 kB
react-northstar
Button		 83.148 kB
25.952 kB
react-northstar
Card		 82.696 kB
25.036 kB
react-northstar
Carousel		 105.173 kB
31.872 kB
react-northstar
Chat		 154.081 kB
46.876 kB
react-northstar
Checkbox		 79.795 kB
25.08 kB
react-northstar
Datepicker		 186.642 kB
56.99 kB
react-northstar
Debug		 8.801 kB
3.594 kB
react-northstar
Design		 36.589 kB
12.067 kB
react-northstar
Dialog		 112.049 kB
33.622 kB
react-northstar
Divider		 76.607 kB
24.135 kB
react-northstar
Dropdown		 198.202 kB
60.222 kB
react-northstar
Embed		 81.468 kB
25.424 kB
react-northstar
Flex		 47.716 kB
15.443 kB
react-northstar
Form		 92.518 kB
28.888 kB
react-northstar
Grid		 70.572 kB
22.282 kB
react-northstar
Header		 74.744 kB
23.465 kB
react-northstar
Image		 73.579 kB
23.333 kB
react-northstar
Input		 88.337 kB
27.78 kB
react-northstar
ItemLayout		 78.219 kB
24.458 kB
react-northstar
Label		 77.908 kB
24.413 kB
react-northstar
Layout		 75.381 kB
23.803 kB
react-northstar
List		 88.481 kB
27.556 kB
react-northstar
Loader		 78.604 kB
24.733 kB
react-northstar
Menu		 128.593 kB
40.737 kB
react-northstar
MenuButton		 162.999 kB
49.613 kB
react-northstar
Pill		 83.71 kB
26.069 kB
react-northstar
Popup		 135.307 kB
42.257 kB
react-northstar
Portal		 58.329 kB
18.851 kB
react-northstar
Provider		 93.129 kB
29.627 kB
react-northstar
RadioGroup		 83.273 kB
26.053 kB
react-northstar
Reaction		 77.268 kB
24.127 kB
react-northstar
Segment		 76.197 kB
23.896 kB
react-northstar
Skeleton		 77.753 kB
24.205 kB
react-northstar
Slider		 84.261 kB
26.755 kB
react-northstar
SplitButton		 178.237 kB
53.438 kB
react-northstar
Status		 76.26 kB
24.054 kB
react-northstar
SvgIcon		 36.811 kB
11.746 kB
react-northstar
Table		 80.787 kB
25.156 kB
react-northstar
Text		 74.102 kB
23.511 kB
react-northstar
TextArea		 74.236 kB
23.496 kB
react-northstar
Toolbar		 175.048 kB
52.846 kB
react-northstar
Tooltip		 109.964 kB
35.236 kB
react-northstar
Tree		 87.843 kB
27.222 kB
react-northstar
Video		 75.402 kB
23.797 kB
react-overflow
hooks only		 12.808 kB
4.819 kB
react-persona
Persona		 56.194 kB
17.695 kB
react-popover
Popover		 128.329 kB
40.143 kB
react-portal
Portal		 14.563 kB
5.118 kB
react-portal-compat
PortalCompatProvider		 8.39 kB
2.64 kB
react-positioning
usePositioning		 27.057 kB
9.698 kB
react-progress
ProgressBar		 17.084 kB
6.891 kB
react-provider
FluentProvider		 24.623 kB
8.893 kB
react-radio
Radio		 32.672 kB
10.343 kB
react-radio
RadioGroup		 15.762 kB
6.423 kB
react-select
Select		 27.732 kB
10.124 kB
react-slider
Slider		 37.169 kB
12.538 kB
react-spinbutton
SpinButton		 36.06 kB
11.815 kB
react-spinner
Spinner		 25.245 kB
8.539 kB
react-swatch-picker
@fluentui/react-swatch-picker - package		 103.736 kB
30.073 kB
react-switch
Switch		 35.319 kB
11.314 kB
react-table
DataGrid		 160.471 kB
45.539 kB
react-table
Table (Primitives only)		 42.643 kB
13.82 kB
react-table
Table as DataGrid		 131.325 kB
36.373 kB
react-table
Table (Selection only)		 70.512 kB
19.965 kB
react-table
Table (Sort only)		 69.155 kB
19.576 kB
react-tag-picker
@fluentui/react-tag-picker - package		 183.584 kB
55.264 kB
react-tags
InteractionTag		 15.199 kB
6.157 kB
react-tags
Tag		 29.016 kB
9.524 kB
react-tags
TagGroup		 82.197 kB
24.362 kB
react-text
Text - Default		 17.061 kB
6.723 kB
react-text
Text - Wrappers		 20.242 kB
7.048 kB
react-textarea
Textarea		 26.572 kB
9.755 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 35.666 kB
7.453 kB
react-theme
Teams: Light theme		 19.642 kB
5.549 kB
react-timepicker-compat
TimePicker		 107.387 kB
35.758 kB
react-toast
Toast (including Toaster)		 97.816 kB
29.438 kB
react-tooltip
Tooltip		 55.517 kB
19.515 kB
react-utilities
SSRProvider		 180 B
160 B
🤖 This report was generated against 8506c117c51567b6dbf80c7e607873eb73de6452

fabricteam
fabricteam reviewed Sep 18, 2024
View reviewed changes
package.json
@@ -337,7 +337,7 @@
"tsconfig-paths": "4.2.0",
Copy link
Collaborator

@fabricteam fabricteam Sep 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv9 Visual Regression Report

Avatar Converged 2 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.Badge Mask RTL.chromium.png 26 Changed
Avatar Converged.badgeMask.chromium.png 1 Changed
Drawer 1 screenshots
Image Name Diff(in Pixels) Image Type
Drawer.overlay drawer full.chromium.png 1166 Changed

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 18, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
LabelMinimalPerf.default 235 209 1.12:1
AccordionMinimalPerf.default 91 83 1.1:1
ChatDuplicateMessagesPerf.default 157 143 1.1:1
DividerMinimalPerf.default 212 197 1.08:1
FormMinimalPerf.default 237 222 1.07:1
PortalMinimalPerf.default 89 83 1.07:1
ButtonSlotsPerf.default 335 315 1.06:1
DropdownManyItemsPerf.default 404 382 1.06:1
GridMinimalPerf.default 197 186 1.06:1
TreeWith60ListItems.default 92 87 1.06:1
AnimationMinimalPerf.default 306 291 1.05:1
ButtonOverridesMissPerf.default 664 632 1.05:1
ChatMinimalPerf.default 461 441 1.05:1
InputMinimalPerf.default 561 534 1.05:1
ProviderMinimalPerf.default 205 196 1.05:1
SegmentMinimalPerf.default 206 197 1.05:1
AlertMinimalPerf.default 159 153 1.04:1
CarouselMinimalPerf.default 271 261 1.04:1
ListNestedPerf.default 320 308 1.04:1
MenuMinimalPerf.default 520 501 1.04:1
RadioGroupMinimalPerf.default 270 259 1.04:1
TextMinimalPerf.default 197 190 1.04:1
VideoMinimalPerf.default 454 437 1.04:1
BoxMinimalPerf.default 200 195 1.03:1
ListMinimalPerf.default 309 300 1.03:1
IconMinimalPerf.default 385 375 1.03:1
CardMinimalPerf.default 313 306 1.02:1
ChatWithPopoverPerf.default 199 196 1.02:1
DropdownMinimalPerf.default 1445 1416 1.02:1
MenuButtonMinimalPerf.default 956 940 1.02:1
RosterPerf.default 1597 1568 1.02:1
StatusMinimalPerf.default 398 390 1.02:1
AttachmentMinimalPerf.default 86 85 1.01:1
AttachmentSlotsPerf.default 643 639 1.01:1
ItemLayoutMinimalPerf.default 724 715 1.01:1
TableManyItemsPerf.default 1120 1106 1.01:1
CustomToolbarPrototype.default 1536 1516 1.01:1
ToolbarMinimalPerf.default 552 547 1.01:1
TreeMinimalPerf.default 489 484 1.01:1
ButtonMinimalPerf.default 92 92 1:1
EmbedMinimalPerf.default 1891 1893 1:1
FlexMinimalPerf.default 155 155 1:1
LoaderMinimalPerf.default 194 194 1:1
SkeletonMinimalPerf.default 196 196 1:1
AvatarMinimalPerf.default 108 109 0.99:1
HeaderMinimalPerf.default 207 210 0.99:1
HeaderSlotsPerf.default 459 462 0.99:1
TextAreaMinimalPerf.default 289 293 0.99:1
CheckboxMinimalPerf.default 1116 1136 0.98:1
DatepickerMinimalPerf.default 3773 3843 0.98:1
DialogMinimalPerf.default 446 456 0.98:1
ListWith60ListItems.default 383 391 0.98:1
ProviderMergeThemesPerf.default 646 658 0.98:1
SliderMinimalPerf.default 741 760 0.98:1
SplitButtonMinimalPerf.default 2231 2276 0.98:1
TooltipMinimalPerf.default 1281 1302 0.98:1
PopupMinimalPerf.default 336 346 0.97:1
ReactionMinimalPerf.default 216 222 0.97:1
RefMinimalPerf.default 109 112 0.97:1
LayoutMinimalPerf.default 193 202 0.96:1
TableMinimalPerf.default 244 253 0.96:1
ListCommonPerf.default 364 386 0.94:1
ImageMinimalPerf.default 224 247 0.91:1

@mainframev mainframev removed the CI label Sep 18, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Sep 18, 2024 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 632 615 5000
Breadcrumb mount 1644 1701 1000
Checkbox mount 1690 1748 5000
CheckboxBase mount 1511 1469 5000
ChoiceGroup mount 2970 2924 5000
ComboBox mount 659 684 1000
CommandBar mount 6482 6533 1000
ContextualMenu mount 12057 12074 1000
DefaultButton mount 810 820 5000
DetailsRow mount 2156 2219 5000
DetailsRowFast mount 2216 2263 5000
DetailsRowNoStyles mount 2057 2027 5000
Dialog mount 2736 2714 1000
DocumentCardTitle mount 246 247 1000
Dropdown mount 1996 1983 5000
FocusTrapZone mount 1114 1146 5000
FocusZone mount 1111 1071 5000
GroupedList mount 42420 42787 2
GroupedList virtual-rerender 20509 20222 2
GroupedList virtual-rerender-with-unmount 52020 51764 2
GroupedListV2 mount 225 233 2
GroupedListV2 virtual-rerender 215 208 2
GroupedListV2 virtual-rerender-with-unmount 232 238 2
IconButton mount 1141 1136 5000
Label mount 350 340 5000
Layer mount 2738 2706 5000
Link mount 384 382 5000
MenuButton mount 984 952 5000
MessageBar mount 21119 21171 5000
Nav mount 2052 2027 1000
OverflowSet mount 763 772 5000
Panel mount 1861 1777 1000
Persona mount 753 763 1000
Pivot mount 905 896 1000
PrimaryButton mount 918 922 5000
Rating mount 4599 4680 5000
SearchBox mount 912 915 5000
Shimmer mount 1956 1920 5000
Slider mount 1336 1337 5000
SpinButton mount 2978 2910 5000
Spinner mount 386 384 5000
SplitButton mount 1907 1846 5000
Stack mount 416 418 5000
StackWithIntrinsicChildren mount 841 873 5000
StackWithTextChildren mount 2791 2727 5000
SwatchColorPicker mount 6593 6431 5000
TagPicker mount 1450 1475 5000
Text mount 371 378 5000
TextField mount 958 935 5000
ThemeProvider mount 847 842 5000
ThemeProvider virtual-rerender 590 604 5000
ThemeProvider virtual-rerender-with-unmount 1304 1305 5000
Toggle mount 600 597 5000
buttonNative mount 189 192 5000

@mainframev mainframev force-pushed the chore/ts-update branch 2 times, most recently from e8f410a to 877529c Compare September 18, 2024 13:41
mainframev
mainframev commented Sep 18, 2024
View reviewed changes
packages/web-components/src/theme/design-tokens.ts
@@ -2615,3 +2615,51 @@ export const curveEasyEase = 'var(--curveEasyEase)';
* @public
*/
export const curveLinear = 'var(--curveLinear)';

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got updated after #32356

fabricteam
fabricteam reviewed Sep 19, 2024
View reviewed changes
apps/react-18-tests-v8/tsconfig.cy.json
@@ -4,6 +4,7 @@
"jsx": "react",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv8 Visual Regression Report

react-charting-LineChart 1 screenshots
Image Name Diff(in Pixels) Image Type
react-charting-LineChart.Gaps.chromium.png 1 Changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@marcosmoura marcosmoura Awaiting requested review from marcosmoura marcosmoura will be requested when the pull request is marked ready for review marcosmoura is a code owner

@chpalac chpalac Awaiting requested review from chpalac chpalac will be requested when the pull request is marked ready for review chpalac is a code owner

@ling1726 ling1726 Awaiting requested review from ling1726 ling1726 will be requested when the pull request is marked ready for review ling1726 is a code owner

@dzearing dzearing Awaiting requested review from dzearing dzearing will be requested when the pull request is marked ready for review dzearing is a code owner

@micahgodbolt micahgodbolt Awaiting requested review from micahgodbolt micahgodbolt will be requested when the pull request is marked ready for review micahgodbolt is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Area: Build System Area: Typescript web-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mainframev @fabricteam