-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed chartsV8 dependency from chartsV9 testcase files. #32869
base: usr/atisjai/chartsV9
Are you sure you want to change the base?
Removed chartsV8 dependency from chartsV9 testcase files. #32869
Conversation
beforeEach(() => { | ||
sharedBeforeEach(); | ||
|
||
root = document.createElement('div'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why removing this code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I push the new updates; I revert back the previous code and now only removed the "sharedBeforeEach();" line.
afterEach(sharedAfterEach); | ||
|
||
test('Should reflect theme change', () => { | ||
// Arrange | ||
const { container } = render( | ||
<ThemeProvider theme={DarkTheme}> | ||
<FluentProvider theme={{ colorNeutralBackground1: '#ccc' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which color does this #ccc represent? Like why are you checking for this specific color?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The color "#ccc" represents a light gray color. It is often used as a neutral background color and I take this color is referenced from the "react-components/react-portal-compat" package.
Previous Behavior
ChartsV9 is using some dependency from chartsV8 in there testcase files.
New Behavior
Removed chartsV8 dependency from chartsV9 testcase files.
Removed dep.: 1. resetIds, 2. DarkTheme, 3. DefaultPalette, 4. mergeStyles.
Replace the 'ThemeProvider' with "FluentProvider".