Security: Ensure type safety of dependent fields #33486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
fabricteam
reviewed
Dec 18, 2024
change/@fluentui-react-charting-f56dc096-9891-4d5c-ae30-4d8a6ac5b481.json
Show resolved
Hide resolved
AtishayMsft
reviewed
Dec 18, 2024
packages/charts/react-charting/src/components/DeclarativeChart/PlotlySchemaAdapter.ts
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Dec 18, 2024
packages/charts/react-charting/src/components/DeclarativeChart/PlotlySchemaAdapter.ts
Show resolved
Hide resolved
AtishayMsft
reviewed
Dec 18, 2024
packages/charts/react-charting/src/components/DeclarativeChart/PlotlySchemaAdapter.ts
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Dec 18, 2024
packages/charts/react-charting/src/components/DeclarativeChart/PlotlySchemaAdapter.ts
Outdated
Show resolved
Hide resolved
AtishayMsft
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
Ensured type safety of these fields in plotly adapater
layout.width
layout.height
firstData.textfont?.size and other fields.
For eg: If the attacker can supply a payload which has a string value for firstData.textfont?.size property such as
14px; background-image: url(...)I don't expect the style library to provide protection in this case.Related Issue(s)