skip MIGRATE for slot verification

microsoft · Jul 8, 2024 · 71e29f3 · 71e29f3
1 parent 5f93240
commit 71e29f3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/libs/server/Resp/Parser/RespCommand.cs b/libs/server/Resp/Parser/RespCommand.cs
@@ -333,6 +333,9 @@ public static RespCommand LastWriteCommand()
         public static bool IsReadOnly(this RespCommand cmd)
             => cmd <= LastReadCommand();
 
+        public static bool IsDataCommand(this RespCommand cmd)
+            => cmd >= FirstReadCommand() && cmd <= LastWriteCommand();
+
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static bool IsWriteOnly(this RespCommand cmd)
         {

diff --git a/libs/server/Resp/RespServerSessionSlotVerify.cs b/libs/server/Resp/RespServerSessionSlotVerify.cs
@@ -40,8 +40,10 @@ bool CanServeSlot(RespCommand cmd)
             if (cmd == RespCommand.NONE)
                 return true;
 
-            //if (RespCommand.ZDIFF == cmd)
-            //    return true;
+            // Verify slot for command if it falls into data command category
+            // TODO: Skip validation of MIGRATE until refactoring of parsing is complete.
+            if (!cmd.IsDataCommand() || cmd == RespCommand.MIGRATE)
+                return true;
 
             cmd = cmd.NormalizeForACLs();
             if (!RespCommandsInfo.TryFastGetRespCommandInfo(cmd, out var commandInfo))