fix edge cases for centralized slot verification

microsoft · Jul 8, 2024 · b144d93 · b144d93
1 parent 66e1790
commit b144d93
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 9 deletions.
diff --git a/libs/server/Resp/Parser/RespCommand.cs b/libs/server/Resp/Parser/RespCommand.cs
@@ -334,7 +334,17 @@ public static bool IsReadOnly(this RespCommand cmd)
             => cmd <= LastReadCommand();
 
         public static bool IsDataCommand(this RespCommand cmd)
-            => cmd >= FirstReadCommand() && cmd <= LastWriteCommand();
+        {
+            return cmd switch
+            {
+                // TODO: validate if these cases need to be excluded
+                RespCommand.MIGRATE => false,
+                RespCommand.DBSIZE => false,
+                RespCommand.MEMORY_USAGE => false,
+                RespCommand.FLUSHDB => false,
+                _ => cmd >= FirstReadCommand() && cmd <= LastWriteCommand()
+            };
+        }
 
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static bool IsWriteOnly(this RespCommand cmd)

diff --git a/libs/server/Resp/RespServerSession.cs b/libs/server/Resp/RespServerSession.cs
@@ -351,7 +351,7 @@ private void ProcessMessages()
                 }
 
                 // Check ACL permissions for the command
-                if (cmd != RespCommand.INVALID && CanServeSlot(cmd) && CheckACLPermissions(cmd))
+                if (cmd != RespCommand.INVALID && CheckACLPermissions(cmd))
                 {
                     if (txnManager.state != TxnState.None)
                     {
@@ -370,7 +370,9 @@ private void ProcessMessages()
                     }
                     else
                     {
-                        _ = ProcessBasicCommands(cmd, ref basicGarnetApi);
+                        // Check if can serve slot for provided keys
+                        if (CanServeSlot(cmd))
+                            _ = ProcessBasicCommands(cmd, ref basicGarnetApi);
                     }
                 }
 

diff --git a/libs/server/Resp/RespServerSessionSlotVerify.cs b/libs/server/Resp/RespServerSessionSlotVerify.cs
@@ -36,13 +36,8 @@ bool CanServeSlot(RespCommand cmd)
             if (clusterSession == null)
                 return true;
 
-            // If this is a UNKNOWN command let process message generate the appropriate response
-            if (cmd == RespCommand.NONE)
-                return true;
-
             // Verify slot for command if it falls into data command category
-            // TODO: Skip validation of MIGRATE until refactoring of parsing is complete.
-            if (!cmd.IsDataCommand() || cmd == RespCommand.MIGRATE)
+            if (!cmd.IsDataCommand())
                 return true;
 
             cmd = cmd.NormalizeForACLs();