Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compatibility] Added GEOSEARCHSTORE command and bug fix in GEOSEARCH command #726

Merged
merged 11 commits into from
Oct 25, 2024

Conversation

Vijay-Nirmal
Copy link
Contributor

Adding the GEOSEARCHSTORE command to garnet and a bug fix in the response structure of the GEOSEARCH command

  • Add GEOSEARCHSTORE command
  • Add Integration Test cases, ACL Test and Slot Verification Test
  • Add documentation
  • Bug fix in the response structure of GEOSEARCH command where it returns data in unexpected RESP format
  • Add new test case to GEOSEARCH command using SE.Redis

@TalZaccai TalZaccai requested a review from yrajas October 17, 2024 18:15
@badrishc
Copy link
Contributor

@PaulusParssinen - can you take a look at this since it may be related to your earlier work? Thanks!

@yrajas
Copy link
Contributor

yrajas commented Oct 23, 2024

Thanks for adding support for more commands.
Could you please check the failing tests?

@Vijay-Nirmal
Copy link
Contributor Author

@yrajas Test case failure will be fixed as part of #748

@yrajas yrajas merged commit d17f489 into microsoft:main Oct 25, 2024
15 checks passed
@Vijay-Nirmal Vijay-Nirmal deleted the new/geosearchstore-command branch October 25, 2024 04:40
@TalZaccai
Copy link
Contributor

@Vijay-Nirmal Hi Vijay! Unfortunately we've noticed some issues after this PR was merged, could you please recreate it so I can review it as well?
Thanks & apologies for the inconvenience...

@Vijay-Nirmal Vijay-Nirmal restored the new/geosearchstore-command branch October 26, 2024 06:51
@Vijay-Nirmal
Copy link
Contributor Author

@TalZaccai Created the PR #752

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants