-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Compatibility] Added GEOSEARCHSTORE command and bug fix in GEOSEARCH command #726
Merged
yrajas
merged 11 commits into
microsoft:main
from
Vijay-Nirmal:new/geosearchstore-command
Oct 25, 2024
Merged
[Compatibility] Added GEOSEARCHSTORE command and bug fix in GEOSEARCH command #726
yrajas
merged 11 commits into
microsoft:main
from
Vijay-Nirmal:new/geosearchstore-command
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@PaulusParssinen - can you take a look at this since it may be related to your earlier work? Thanks! |
Thanks for adding support for more commands. |
yrajas
reviewed
Oct 23, 2024
yrajas
approved these changes
Oct 25, 2024
@Vijay-Nirmal Hi Vijay! Unfortunately we've noticed some issues after this PR was merged, could you please recreate it so I can review it as well? |
@TalZaccai Created the PR #752 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the GEOSEARCHSTORE command to garnet and a bug fix in the response structure of the GEOSEARCH command