-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing BDN Perf pipeline #758
Open
darrenge
wants to merge
48
commits into
main
Choose a base branch
from
darrenge/BDNPerf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 47 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
a81a31e
The CI scripts, YML and config files to check perf using BDN benchmar…
darrenge f66f63f
Cleaned up the debug message and updated couple expected values
darrenge b0c8cc4
Updated SAddRem - windows - to 130 from 118. Also removed unncesssar…
darrenge 2b0ec1f
Proof of concept for Performance run on ADO using BDN
darrenge ebd13e4
Comment out number of Cores check so can try proof of concept on ADO …
darrenge fb8ee2b
Merged
darrenge 37d12df
Getting close to having BDN working
darrenge b97f807
Fixed RespLuaStress
darrenge ba45091
Fixed issue in Lua Runner Stress
darrenge bff5a21
Updated config values, set charting and commit comment as separate tasks
darrenge 83169ef
Updated config values
darrenge cd17683
Minor change to YML (remove pull requests) and updated LuaRunner conf…
darrenge b334f65
One more config value fix
darrenge 4df29ee
Added a task to do the push
darrenge 82f6f15
Putting back to push chart in the chart task and not a separate one
darrenge 58038d1
Moved the permissions to full workflow
darrenge 5875d87
Just minor to add commits
darrenge d69a07b
Adding actions: write permit since actions default to read only
darrenge 68d0972
Set up the commit comment for BDN as well as summary to show current …
darrenge f8ddb6c
A few fixes
darrenge 8e05865
Updated BDN perf YML, config files and ps1 script
darrenge 4008726
Versioning issue with BDN test files, fixed now
darrenge 82881ff
Merge branch 'main' into darrenge/BDNPerf
darrenge cdf2d25
Bump threshold to 35% (135%) to trigger perf failure
darrenge 00b3674
Set to Linux only to reduce number of consectutive tests which caused…
darrenge 414168e
Just Windows only test run
darrenge 28ccbb4
Putting it back to both OS for the tests
darrenge 23296d6
Set threshhold to 50% (150%) as seeing BDN ran twice on same code som…
darrenge 1f36768
Big change where using continuousbenchmark branch for all data for co…
darrenge ef0cf7b
Updated ClusterBench to get main changes
darrenge df16e9c
Merge branch 'main' into darrenge/BDNPerf
darrenge d5953a2
Fix issue with Cluster BDN is not able to access folder so setting to…
darrenge d58bf0d
Bumping threshold to 50% (150%) as mean value in RespParseStress can …
darrenge 6414fac
Merged Main
darrenge 75e78c3
First update
darrenge 40e111c
Merge branch 'main' into darrenge/BDNPerf
darrenge e22218c
Hiding the Gen0 column for Lua benchmark
darrenge b609c0c
Merge branch 'main' into darrenge/BDNPerf
darrenge f9a963b
Updated BDN test infrastructure to match the new BDN org.
darrenge 665bda1
Fix bug in ObjectOperations
darrenge 0d1fd6f
Set max items on chart to 50 ... can modify later if want
darrenge da030c6
Merge branch 'main' into darrenge/BDNPerf
darrenge 6725d99
Added the run on push to main
darrenge da6b517
Put Performance Pipeline back
darrenge 3871a3f
Fixed the default case when no parameters sent to ps1
darrenge 3d6d7b2
Merge branch 'main' into darrenge/BDNPerf
darrenge 591fadc
Merge branch 'main' into darrenge/BDNPerf
darrenge bf06727
Cleaned up config files:
darrenge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
test/BDNPerfTests/ConfigFiles/CI_CONFIG_BDN_Benchmark_Cluster.ClusterMigrate.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
{ | ||
"configuration": "Release", | ||
"framework": "net8.0", | ||
"filter": "BDN.benchmark.Cluster.ClusterMigrate.*", | ||
|
||
"expectedGet_None_AllocatedValue_linux": 0, | ||
"expectedSet_None_AllocatedValue_linux": 0, | ||
"expectedMGet_None_AllocatedValue_linux": 0, | ||
"expectedMSet_None_AllocatedValue_linux": 0, | ||
|
||
"expectedGet_None_AllocatedValue_win": 0, | ||
"expectedSet_None_AllocatedValue_win": 0, | ||
"expectedMGet_None_AllocatedValue_win": 0, | ||
"expectedMSet_None_AllocatedValue_win": 0, | ||
|
||
"acceptableAllocatedRange": 10, | ||
"acceptableError": ".1", | ||
"acceptableStdDev": ".1" | ||
} |
31 changes: 31 additions & 0 deletions
31
test/BDNPerfTests/ConfigFiles/CI_CONFIG_BDN_Benchmark_Cluster.ClusterOperations.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
{ | ||
"configuration": "Release", | ||
"framework": "net8.0", | ||
"filter": "BDN.benchmark.Cluster.ClusterOperations.*", | ||
|
||
"expectedGet_DSV_AllocatedValue_linux": 0, | ||
"expectedSet_DSV_AllocatedValue_linux": 0, | ||
"expectedMGet_DSV_AllocatedValue_linux": 0, | ||
"expectedMSet_DSV_AllocatedValue_linux": 0, | ||
"expectedCPBSet_DSV_AllocatedValue_linux": 0, | ||
"expectedGet_None_AllocatedValue_linux": 0, | ||
"expectedSet_None_AllocatedValue_linux": 0, | ||
"expectedMGet_None_AllocatedValue_linux": 0, | ||
"expectedMSet_None_AllocatedValue_linux": 0, | ||
"expectedCPBSet_None_AllocatedValue_linux": 0, | ||
|
||
"expectedGet_DSV_AllocatedValue_win": 0, | ||
"expectedSet_DSV_AllocatedValue_win": 0, | ||
"expectedMGet_DSV_AllocatedValue_win": 0, | ||
"expectedMSet_DSV_AllocatedValue_win": 0, | ||
"expectedCPBSet_DSV_AllocatedValue_win": 0, | ||
"expectedGet_None_AllocatedValue_win": 0, | ||
"expectedSet_None_AllocatedValue_win": 0, | ||
"expectedMGet_None_AllocatedValue_win": 0, | ||
"expectedMSet_None_AllocatedValue_win": 0, | ||
"expectedCPBSet_None_AllocatedValue_win": 0, | ||
|
||
"acceptableAllocatedRange": 10, | ||
darrenge marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"acceptableError": ".1", | ||
"acceptableStdDev": ".1" | ||
} |
19 changes: 19 additions & 0 deletions
19
test/BDNPerfTests/ConfigFiles/CI_CONFIG_BDN_Benchmark_Lua.LuaScripts.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
{ | ||
"configuration": "Release", | ||
darrenge marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"framework": "net8.0", | ||
"filter": "BDN.benchmark.Lua.*", | ||
|
||
"expectedScript1_None_AllocatedValue_linux": 24, | ||
darrenge marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"expectedScript2_None_AllocatedValue_linux": 144, | ||
"expectedScript3_None_AllocatedValue_linux": 240, | ||
"expectedScript4_None_AllocatedValue_linux": 776, | ||
|
||
"expectedScript1_None_AllocatedValue_win": 24, | ||
"expectedScript2_None_AllocatedValue_win": 144, | ||
"expectedScript3_None_AllocatedValue_win": 240, | ||
"expectedScript4_None_AllocatedValue_win": 776, | ||
|
||
"acceptableAllocatedRange": 10, | ||
"acceptableError": ".1", | ||
"acceptableStdDev": ".1" | ||
} |
17 changes: 17 additions & 0 deletions
17
test/BDNPerfTests/ConfigFiles/CI_CONFIG_BDN_Benchmark_Operations.BasicOperations.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
{ | ||
"configuration": "Release", | ||
darrenge marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"framework": "net8.0", | ||
"filter": "BDN.benchmark.Operations.BasicOperations.*", | ||
|
||
"expectedInlinePing_ACL_AllocatedValue_linux": 0, | ||
"expectedInlinePing_AOF_AllocatedValue_linux": 0, | ||
"expectedInlinePing_None_AllocatedValue_linux": 0, | ||
|
||
"expectedInlinePing_ACL_AllocatedValue_win": 0, | ||
"expectedInlinePing_AOF_AllocatedValue_win": 0, | ||
"expectedInlinePing_None_AllocatedValue_win": 0, | ||
|
||
"acceptableAllocatedRange": 10, | ||
"acceptableError": ".1", | ||
"acceptableStdDev": ".1" | ||
} |
53 changes: 53 additions & 0 deletions
53
test/BDNPerfTests/ConfigFiles/CI_CONFIG_BDN_Benchmark_Operations.ObjectOperations.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
{ | ||
"configuration": "Release", | ||
"framework": "net8.0", | ||
"filter": "BDN.benchmark.Operations.ObjectOperations.*", | ||
|
||
"expectedZAddRem_ACL_AllocatedValue_linux": 18400, | ||
darrenge marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"expectedLPushPop_ACL_AllocatedValue_linux": 14400, | ||
"expectedSAddRem_ACL_AllocatedValue_linux": 12800, | ||
"expectedHSetDel_ACL_AllocatedValue_linux": 43201, | ||
"expectedMyDictSetGet_ACL_AllocatedValue_linux": 24000, | ||
"expectedCustomProcSet_ACL_AllocatedValue_linux": 0, | ||
|
||
"expectedZAddRem_AOF_AllocatedValue_linux": 18400, | ||
"expectedLPushPop_AOF_AllocatedValue_linux": 14400, | ||
"expectedSAddRem_AOF_AllocatedValue_linux": 12800, | ||
"expectedHSetDel_AOF_AllocatedValue_linux": 43201, | ||
"expectedMyDictSetGet_AOF_AllocatedValue_linux": 24000, | ||
"expectedCustomProcSet_AOF_AllocatedValue_linux": 0, | ||
|
||
"expectedZAddRem_None_AllocatedValue_linux": 18400, | ||
"expectedLPushPop_None_AllocatedValue_linux": 14400, | ||
"expectedSAddRem_None_AllocatedValue_linux": 12800, | ||
"expectedHSetDel_None_AllocatedValue_linux": 43201, | ||
"expectedMyDictSetGet_None_AllocatedValue_linux": 24000, | ||
"expectedCustomProcSet_None_AllocatedValue_linux": 0, | ||
|
||
|
||
"expectedZAddRem_ACL_AllocatedValue_win": 18400, | ||
"expectedLPushPop_ACL_AllocatedValue_win": 14400, | ||
"expectedSAddRem_ACL_AllocatedValue_win": 12800, | ||
"expectedHSetDel_ACL_AllocatedValue_win": 43201, | ||
"expectedMyDictSetGet_ACL_AllocatedValue_win": 24000, | ||
"expectedCustomProcSet_ACL_AllocatedValue_win": 0, | ||
|
||
"expectedZAddRem_AOF_AllocatedValue_win": 18400, | ||
"expectedLPushPop_AOF_AllocatedValue_win": 14400, | ||
"expectedSAddRem_AOF_AllocatedValue_win": 12800, | ||
"expectedHSetDel_AOF_AllocatedValue_win": 43201, | ||
"expectedMyDictSetGet_AOF_AllocatedValue_win": 24000, | ||
"expectedCustomProcSet_AOF_AllocatedValue_win": 0, | ||
|
||
"expectedZAddRem_None_AllocatedValue_win": 18400, | ||
"expectedLPushPop_None_AllocatedValue_win": 14400, | ||
"expectedSAddRem_None_AllocatedValue_win": 12800, | ||
"expectedHSetDel_None_AllocatedValue_win": 43201, | ||
"expectedMyDictSetGet_None_AllocatedValue_win": 24000, | ||
"expectedCustomProcSet_None_AllocatedValue_win": 0, | ||
|
||
"acceptableAllocatedRange": 10, | ||
"acceptableError": ".1", | ||
"acceptableStdDev": ".1" | ||
} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should only have to add files and entries with a non-zero allocated target. the script should assume, if it does not find a benchmark entry, that the allocated should be zero. that way this entire file gets deleted. and, many lines in other files get deleted as well. will make maintenance a tad easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see where you are coming from but not sure I agree with this. Maintenance is easiest if it is consistent so we know one config file per BDN run. Also, assuming it should be zero if not there is an assumption and it might be better to specifically state to show we know it should be zero. Currently, the BDN name/ filter is in the config file as well, so that would be a change to only just use the test name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are only pulling values we need for the specific test (based on other comment), we need to know what values we need for that specific test. Those specific values are in the config file, so I think it only makes sense to have all config files even if the values are 0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could have one config file that has a section per test. for every test we add we would simply run the test, and for every result, we would comare it to either zero (by default) or an override (if specified in the JSON).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I guess that would be another way to implement it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try to implement it with one config file for all BDN test runs