Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy CI benchmark charts into website publishing action #759

Merged
merged 7 commits into from
Oct 31, 2024

Conversation

badrishc
Copy link
Contributor

  • Grabs the latest charts from the branch continuousbenchmark, in the folder website/static/charts
  • Copies the charts into the static folder before running yarn
  • The pages deploy is updated to trigger on both main and continuousbenchmark branches

After merge, the benchmarking history charts should be available at https://microsoft.github.io/garnet/charts

@darrenge
Copy link
Contributor

I am not sure you want to do this on every push to continuousbenchmark. Every time the BDN perf CI runs, it runs 10 BDN tests (5 tests on linux and windows). After each of those are finished, they push to continuousbenchmark. That means for every BDN CI, this one will be ran 10 times. I do understand the timing of it though that if you do it on Main, you won't get the most up to date data on the site for that specific push. We could try it and just see how it goes.

Copy link
Contributor

@darrenge darrenge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be ok if this is called 10 times every time the BDN perf pipeline is called.

@badrishc
Copy link
Contributor Author

Fixed to run once only when ci-bdnbenchmark completes, not on every checkin to that branch.

@badrishc badrishc merged commit 545ff8e into microsoft:main Oct 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants