Add animation channels and skins to merged object list. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that each LOD document has the same number and order of animations that should be cumulative in the output document.
robertos
reviewed
Feb 8, 2018
glTF-Toolkit/src/GLTFLODUtils.cpp
Outdated
| AddIndexOffset(skin.skeletonId, nodeOffset); | ||
| AddIndexOffset(skin.inverseBindMatricesAccessorId, accessorOffset); | ||
|
|
||
| for (auto Itr = skin.jointIds.begin(); Itr != skin.jointIds.end(); Itr++) |
There was a problem hiding this comment.
why not for (auto joint : skin.jointIds) ?
There was a problem hiding this comment.
Following the node.children pattern above
There was a problem hiding this comment.
I believe you can fix that too then, if possible :)
robertos
reviewed
Feb 8, 2018
| { | ||
| // post-fix with lod level indication; | ||
| // no functional reason other than making it easier to natively read gltf files with lods | ||
| skin.name += nodeLodLabel; |
There was a problem hiding this comment.
Are the skin names never used directly?
There was a problem hiding this comment.
also this is copy/paste from node above
robertos
suggested changes
Feb 8, 2018
robertos
approved these changes
Feb 8, 2018
added 2 commits
February 7, 2018 16:32
|
I'll merge this as soon as CI passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assumes that each LOD document has the same number and order of animations that should be cumulative in the output document.