Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Handle extended chars in SQL instance names #138

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Fix: Handle extended chars in SQL instance names #138

merged 2 commits into from
Jul 25, 2023

Conversation

shueybubbles
Copy link
Collaborator

I couldn't find a standard package for converting the style of ASCII encoding that SQL uses into a UTF8 Go string, nor could I find something to convert from UTF8 to that ASCII byte array. strconv.QuoteToASCII is the only common conversion function I could find.
I was hoping to change the browser message we use to 4 which takes the instance name as parameter, but without the conversion to ASCII byte array I can use it.

apoorvdeshmukh
apoorvdeshmukh approved these changes Jul 25, 2023
View reviewed changes
Copy link

@apoorvdeshmukh apoorvdeshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@shueybubbles shueybubbles merged commit 7804e0c into main Jul 25, 2023
@shueybubbles shueybubbles deleted the shueybubbles/122 branch July 25, 2023 18:46
@shueybubbles
Copy link
Collaborator Author

Fixes #122

kodiakhq bot referenced this pull request in cloudquery/cloudquery Aug 22, 2023
@cq-bot
fix(deps): Update module github.com/microsoft/go-mssqldb to v1 (#13272)
a8bb5fd 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/microsoft/go-mssqldb](https://github.com/microsoft/go-mssqldb) | require | major | `v0.19.0` -> `v1.5.0` |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>microsoft/go-mssqldb (github.com/microsoft/go-mssqldb)</summary>

### [`v1.5.0`](https://github.com/microsoft/go-mssqldb/releases/tag/v1.5.0)

[Compare Source](https://github.com/microsoft/go-mssqldb/compare/v1.4.0...v1.5.0)

#### What's Changed

-   go mod vendor npipe to this repo by [@&#8203;shueybubbles](https://github.com/shueybubbles) in [https://github.com/microsoft/go-mssqldb/pull/118](https://github.com/microsoft/go-mssqldb/pull/118)
-   Enable dependabot for pkg updates by [@&#8203;apoorvdeshmukh](https://github.com/apoorvdeshmukh) in [https://github.com/microsoft/go-mssqldb/pull/119](https://github.com/microsoft/go-mssqldb/pull/119)
-   fix: mips and mipsel builds by [@&#8203;powersj](https://github.com/powersj) in [https://github.com/microsoft/go-mssqldb/pull/124](https://github.com/microsoft/go-mssqldb/pull/124)
-   Allow for local dns resolution with a custom dialer by [@&#8203;stephaniehingtgen](https://github.com/stephaniehingtgen) in [https://github.com/microsoft/go-mssqldb/pull/121](https://github.com/microsoft/go-mssqldb/pull/121)
-   Fixes MarshalText and adds UnmarshalJSON interface for UniqueIdentifier by [@&#8203;Musab-Nazir](https://github.com/Musab-Nazir) in [https://github.com/microsoft/go-mssqldb/pull/126](https://github.com/microsoft/go-mssqldb/pull/126)
-   Update README.md by [@&#8203;dlevy-msft](https://github.com/dlevy-msft) in [https://github.com/microsoft/go-mssqldb/pull/132](https://github.com/microsoft/go-mssqldb/pull/132)
-   Fix: Handle extended chars in SQL instance names by [@&#8203;shueybubbles](https://github.com/shueybubbles) in [https://github.com/microsoft/go-mssqldb/pull/138](https://github.com/microsoft/go-mssqldb/pull/138)

#### New Contributors

-   [@&#8203;powersj](https://github.com/powersj) made their first contribution in [https://github.com/microsoft/go-mssqldb/pull/124](https://github.com/microsoft/go-mssqldb/pull/124)
-   [@&#8203;stephaniehingtgen](https://github.com/stephaniehingtgen) made their first contribution in [https://github.com/microsoft/go-mssqldb/pull/121](https://github.com/microsoft/go-mssqldb/pull/121)
-   [@&#8203;Musab-Nazir](https://github.com/Musab-Nazir) made their first contribution in [https://github.com/microsoft/go-mssqldb/pull/126](https://github.com/microsoft/go-mssqldb/pull/126)
-   [@&#8203;dlevy-msft](https://github.com/dlevy-msft) made their first contribution in [https://github.com/microsoft/go-mssqldb/pull/132](https://github.com/microsoft/go-mssqldb/pull/132)

**Full Changelog**: microsoft/go-mssqldb@v1.1.0...v1.5.0

### [`v1.4.0`](https://github.com/microsoft/go-mssqldb/compare/v1.3.0...v1.4.0)

[Compare Source](https://github.com/microsoft/go-mssqldb/compare/v1.3.0...v1.4.0)

### [`v1.3.0`](https://github.com/microsoft/go-mssqldb/compare/v1.2.0...v1.3.0)

[Compare Source](https://github.com/microsoft/go-mssqldb/compare/v1.2.0...v1.3.0)

### [`v1.2.0`](https://github.com/microsoft/go-mssqldb/compare/v1.1.0...v1.2.0)

[Compare Source](https://github.com/microsoft/go-mssqldb/compare/v1.1.0...v1.2.0)

### [`v1.1.0`](https://github.com/microsoft/go-mssqldb/releases/tag/v1.1.0)

[Compare Source](https://github.com/microsoft/go-mssqldb/compare/v1.0.0...v1.1.0)

### Version 1.1.0

-   Release date: May 30, 2023

#### What's new in 1.1.0

-   Supports finding the DAC port using the browser service ([#&#8203;110](https://github.com/microsoft/go-mssqldb/issues/110))
-   Updated go package dependencies ([#&#8203;112](https://github.com/microsoft/go-mssqldb/issues/112))

### [`v1.0.0`](https://github.com/microsoft/go-mssqldb/compare/v0.21.0...v1.0.0)

[Compare Source](https://github.com/microsoft/go-mssqldb/compare/v0.21.0...v1.0.0)

### [`v0.21.0`](https://github.com/microsoft/go-mssqldb/compare/v0.20.0...v0.21.0)

[Compare Source](https://github.com/microsoft/go-mssqldb/compare/v0.20.0...v0.21.0)

### [`v0.20.0`](https://github.com/microsoft/go-mssqldb/compare/v0.19.0...v0.20.0)

[Compare Source](https://github.com/microsoft/go-mssqldb/compare/v0.19.0...v0.20.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41NC4yIiwidXBkYXRlZEluVmVyIjoiMzYuNTQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorvdeshmukh apoorvdeshmukh apoorvdeshmukh approved these changes

@stuartpa stuartpa Awaiting requested review from stuartpa

@JyotikaGargg JyotikaGargg Awaiting requested review from JyotikaGargg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shueybubbles @apoorvdeshmukh