Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add tracing data to prelogin and login7 packets #228

Merged
merged 7 commits into from
Dec 5, 2024

Conversation

shueybubbles
Copy link
Collaborator

Fixes #226 .
I'm not ready to figure out how to maintain a sequence number update across redirects; there's not a clear place to store it.
I plan to have at least one more push to implement a Log method on tdsSession that prepends the activity id and the connection id to all the session-specific driver trace messages. I want to replace code like this:

if c.sess.logFlags&logRetries != 0 {
	c.sess.logger.Log(ctx, msdsn.LogRetries, err.Error())
}

with this:

c.sess.Log(ctx, msdsn.LogRetries, err.Error())

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 88.70968% with 14 lines in your changes missing coverage. Please review.

Project coverage is 74.85%. Comparing base (2521238) to head (2bff9dd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tds.go 72.00% 5 Missing and 2 partials ⚠️
session.go 94.28% 4 Missing ⚠️
bulkcopy.go 0.00% 1 Missing ⚠️
mssql.go 91.66% 1 Missing ⚠️
token.go 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   74.45%   74.85%   +0.39%     
==========================================
  Files          32       32              
  Lines        6397     6410      +13     
==========================================
+ Hits         4763     4798      +35     
+ Misses       1352     1327      -25     
- Partials      282      285       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@apoorvdeshmukh apoorvdeshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good! Thanks for fixing the tests. :shipit:

@shueybubbles shueybubbles merged commit dad23d2 into main Dec 5, 2024
10 checks passed
@shueybubbles shueybubbles deleted the shueybubbles/226 branch December 5, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prelogin and login7 messages are missing some fields, leading to connection failures against certain endpoints
3 participants