-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to go1.18, drop go1.18, and replace deprecated syscall.Syscall<number> #283
base: main
Are you sure you want to change the base?
Conversation
r1, _, e1 := syscall.Syscall(procbind.Addr(), 3, uintptr(s), uintptr(name), uintptr(namelen)) | ||
r1, _, e1 := syscall.SyscallN(procbind.Addr(), uintptr(s), uintptr(name), uintptr(namelen)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go generate
unless doing so on a Windows machine).
Not 100% sure if CI here verifies these files (if not, perhaps someone could double-check them and run go generate
on a Windows machine)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure if CI here verifies these files (if not, perhaps someone could double-check them and run
go generate
on a Windows machine)
looks like it does, and CI looks happy; https://github.com/thaJeztah/go-winio/actions/runs/4645965648
1d52ae4
to
7f78199
Compare
wim/lzx/lzx.go:492:3: early-return: if c { ... } else { ... break } can be simplified to if !c { ... break } ... (revive) if matchoffset <= i && matchlen <= end-i { copyend := i + matchlen for ; i < copyend; i++ { f.window[i] = f.window[i-matchoffset] } } else { f.fail(errCorrupt) break } Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
pkg/security: Error: directive `//nolint:structcheck,unused // structcheck thinks fields are unused, but the are used to pass data to OS` is unused for linter "unused" (nolintlint) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
pkg/etw, pkg/etwlogrus: replace interface{} with any (revive) Warning: use-any: since GO 1.18 'interface{}' can be replaced by 'any' (revive) Warning: use-any: since GO 1.18 'interface{}' can be replaced by 'any' (revive) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
….17) The "syscall.Syscall<number>" functions were deprecated in go1.18 in favor of the "syscall.SyscallN" function, which does not need the "nargs" argument, and does not need the list of arguments to be padded with zeros. https://github.com/golang/go/blob/go1.18/src/syscall/dll_windows.go#L27-L45 Now that go1.17 reached EOL and is no longer maintained, we can update the code to use the new SyscallN function. This patch updates the mkwinsyscall utility to generate code using the new SyscallN function, and removes the utilities that are now redundant. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
7f78199
to
d88b00b
Compare
This should be ready for review /cc @kevpar 😄 (I should probably point out that containerd 1.6 still tests against go1.17 as "old version", in case this version from main ends up in containerd at some point; https://github.com/containerd/containerd/blob/v1.6.20/.github/workflows/ci.yml#L236) |
gha: update golangci-lint to v1.52.x
update to go1.18
tools/mkwinsyscall: replace deprecated funcs with SyscallN (drops go1.17)
The "syscall.Syscall" functions were deprecated in go1.18 in favor
of the "syscall.SyscallN" function, which does not need the "nargs" argument,
and does not need the list of arguments to be padded with zeros.
https://github.com/golang/go/blob/go1.18/src/syscall/dll_windows.go#L27-L45
Now that go1.17 reached EOL and is no longer maintained, we can update the
code to use the new SyscallN function. This patch updates the mkwinsyscall
utility to generate code using the new SyscallN function, and removes the
utilities that are now redundant.
internal/socket: replace deprecated syscall.Syscall9