Update containerd-shim-runhcs-v1 tests #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update shim tests to match current shim behavior. Run shim tests in GitHub CI. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
| run: | | ||
| powershell { | ||
| cd '../..' | ||
| go build -trimpath -o './test/containerd-shim-runhcs-v1' ./cmd/containerd-shim-runhcs-v1 |
There was a problem hiding this comment.
Why output this to ./test/containerd-shim-runhcs-v1?
There was a problem hiding this comment.
the shim tests want the executable in the same working directory
katiewasnothere
approved these changes
May 16, 2023
helsaawy
added a commit
to helsaawy/hcsshim
that referenced
this pull request
Sep 8, 2023
Update shim tests to match current shim behavior. Run shim tests in GitHub CI. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> (cherry picked from commit 55f8c42) Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
helsaawy
added a commit
that referenced
this pull request
Sep 8, 2023
kiashok
pushed a commit
to kiashok/hcsshim
that referenced
this pull request
Oct 3, 2023
Update shim tests to match current shim behavior. Run shim tests in GitHub CI. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> (cherry picked from commit 55f8c42) Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
kiashok
pushed a commit
to kiashok/hcsshim
that referenced
this pull request
Oct 3, 2023
Update shim tests to match current shim behavior. Run shim tests in GitHub CI. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> (cherry picked from commit 55f8c42) Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
kiashok
pushed a commit
to kiashok/hcsshim
that referenced
this pull request
Oct 3, 2023
Update shim tests to match current shim behavior. Run shim tests in GitHub CI. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> (cherry picked from commit 55f8c42) Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update shim tests to match current shim behavior.
Run shim tests in GitHub CI.