Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deps]Omni-bus dependency upgrade #1837

Merged
merged 1 commit into from
Jul 11, 2023
Merged

[deps]Omni-bus dependency upgrade #1837

merged 1 commit into from
Jul 11, 2023

Conversation

helsaawy
Copy link
Contributor

@helsaawy helsaawy commented Jul 10, 2023 •
edited
Loading

@helsaawy helsaawy requested a review from a team as a code owner July 10, 2023 17:55
@anmaxvl
Copy link
Contributor

anmaxvl commented Jul 10, 2023

I'd remove the go-cose one, since we have a draft PR which removes the direct dependency.

@helsaawy
[deps]Omni-bus dependency upgrade
ad0f2ab 
Combine several dependabot PRs to deal with `test/go.mod` module issues:

- microsoft#1834
- microsoft#1833
- microsoft#1832
- microsoft#1831
- microsoft#1830
- microsoft#1829
- microsoft#1828
- microsoft#1819
- microsoft#1808

Regenerate proto files since `protoc-gen-go` is updated.

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
katiewasnothere
katiewasnothere approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update PR description list as well, otherwise LGTM :)

@helsaawy helsaawy merged commit 492992f into microsoft:main Jul 11, 2023
@helsaawy helsaawy deleted the deps branch July 11, 2023 21:18
@thaJeztah thaJeztah mentioned this pull request Aug 24, 2023
Closed
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
@helsaawy
[deps]Omni-bus dependency upgrade (microsoft#1837)
7bb7c32 
Combine several dependabot PRs to deal with `test/go.mod` module issues:

- microsoft#1834
- microsoft#1833
- microsoft#1832
- microsoft#1831
- microsoft#1830
- microsoft#1829
- microsoft#1828
- microsoft#1819
- microsoft#1808

Regenerate proto files since `protoc-gen-go` is updated.

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katiewasnothere katiewasnothere katiewasnothere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@helsaawy @anmaxvl @katiewasnothere