Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Omni-bus dependency update #2039

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

@helsaawy helsaawy requested a review from a team as a code owner February 26, 2024 17:19
@anmaxvl
Copy link
Contributor

anmaxvl commented Feb 26, 2024

cool, looks like ACC has updated cosesign1go :) FYI @KenGordon

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Copy link
Contributor

@anmaxvl anmaxvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ran rego tests locally. they look good. LGTM as long as the CI test failures are unrelated.

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Copy link
Contributor

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@helsaawy helsaawy merged commit 8039310 into microsoft:main Feb 26, 2024
18 of 19 checks passed
@helsaawy helsaawy deleted the deps/omni branch February 26, 2024 23:25
@jpayne3506
Copy link

@helsaawy looks like #2010 github.com/open-policy-agent/opa got missed.

Is there plans besides leveraging dependabot #2049 to update?

Would CVE(s) https://github.com/advisories?query=github.com%2Fopen-policy-agent%2Fopa help move the needle?

kiashok pushed a commit to kiashok/hcsshim that referenced this pull request Aug 16, 2024
* [deps] Omni-bus dependency update

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>

* upgrade containerd to see if tests pass

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>

---------

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
(cherry picked from commit 8039310)
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
kiashok pushed a commit to kiashok/hcsshim that referenced this pull request Aug 18, 2024
* [deps] Omni-bus dependency update

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>

* upgrade containerd to see if tests pass

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>

---------

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
(cherry picked from commit 8039310)
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>

.

Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
* [deps] Omni-bus dependency update

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>

* upgrade containerd to see if tests pass

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>

---------

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants