Changes for checking the global version for modify policy version support. #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debj1t
reviewed
May 10, 2024
princepereira
force-pushed
the
user/ppereira/modifyPolicyVersion
branch
2 times, most recently
from
8a23046
to
29907e1
Compare
helsaawy
approved these changes
May 17, 2024
princepereira
force-pushed
the
user/ppereira/modifyPolicyVersion
branch
from
29907e1
to
555a8e1
Compare
sbangari
reviewed
May 20, 2024
princepereira
force-pushed
the
user/ppereira/modifyPolicyVersion
branch
from
555a8e1
to
e609f69
Compare
…port. Signed-off-by: Prince Pereira <ppereira@microsoft.com>
princepereira
force-pushed
the
user/ppereira/modifyPolicyVersion
branch
from
e609f69
to
0daa926
Compare
sourad
approved these changes
Jun 3, 2024
|
/approve |
kiashok
pushed a commit
to kiashok/hcsshim
that referenced
this pull request
Jun 6, 2024
…port. (microsoft#2139) Signed-off-by: Prince Pereira <ppereira@microsoft.com> (cherry picked from commit 8beabac) Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
kiashok
pushed a commit
to kiashok/hcsshim
that referenced
this pull request
Jun 13, 2024
…port. (microsoft#2139) Signed-off-by: Prince Pereira <ppereira@microsoft.com> (cherry picked from commit 8beabac) Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
princepereira
added a commit
to princepereira/hcsshim
that referenced
this pull request
Jun 14, 2024
…port. (microsoft#2139) Signed-off-by: Prince Pereira <ppereira@microsoft.com>
princepereira
added a commit
to princepereira/hcsshim
that referenced
this pull request
Jun 14, 2024
…port. (microsoft#2139) Signed-off-by: Prince Pereira <ppereira@microsoft.com>
princepereira
added a commit
to princepereira/hcsshim
that referenced
this pull request
Jun 14, 2024
…port. (microsoft#2139) Signed-off-by: Prince Pereira <ppereira@microsoft.com>
princepereira
added a commit
to princepereira/hcsshim
that referenced
this pull request
Jun 14, 2024
…port. (microsoft#2139) Signed-off-by: Prince Pereira <ppereira@microsoft.com>
princepereira
added a commit
to princepereira/hcsshim
that referenced
this pull request
Jun 14, 2024
…port. (microsoft#2139) Signed-off-by: Prince Pereira <ppereira@microsoft.com>
princepereira
added a commit
to princepereira/hcsshim
that referenced
this pull request
Jun 19, 2024
…port. (microsoft#2139) Signed-off-by: Prince Pereira <ppereira@microsoft.com>
princepereira
added a commit
to princepereira/hcsshim
that referenced
this pull request
Jun 19, 2024
…port. (microsoft#2139) Signed-off-by: Prince Pereira <ppereira@microsoft.com>
princepereira
added a commit
to princepereira/hcsshim
that referenced
this pull request
Jun 19, 2024
…port. (microsoft#2139) Signed-off-by: Prince Pereira <ppereira@microsoft.com>
kiashok
pushed a commit
that referenced
this pull request
Jun 19, 2024
…port. (#2139) Signed-off-by: Prince Pereira <ppereira@microsoft.com>
kiashok
pushed a commit
that referenced
this pull request
Jun 19, 2024
…port. (#2139) Signed-off-by: Prince Pereira <ppereira@microsoft.com>
kiashok
pushed a commit
that referenced
this pull request
Jun 19, 2024
…port. (#2139) Signed-off-by: Prince Pereira <ppereira@microsoft.com>
princepereira
added a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 28, 2024
…port. (microsoft#2139) Signed-off-by: Prince Pereira <ppereira@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This to check the if the current version of hns supports modify loadbalancer. These functions will be used by Kube proxy to decide whether to go with modify loadbalancer api or not.