ConsoleSize --> uint #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Howard <jhoward@microsoft.com>
darstahl
reviewed
Sep 15, 2016
| @@ -16,7 +16,7 @@ type ProcessConfig struct { | |||
| CreateStdInPipe bool | |||
| CreateStdOutPipe bool | |||
| CreateStdErrPipe bool | |||
| ConsoleSize [2]int | |||
| ConsoleSize [2]uint | |||
There was a problem hiding this comment.
I don't think this is actually used in the platform. We might be ok to just remove it (We already set console size with the ResizeConsole method).
There was a problem hiding this comment.
We should test without it against TP5
There was a problem hiding this comment.
Ah, re TP5: moby/moby#26613 😄. We do use it though to set the initial console size. Following updates are sent through resize.
There was a problem hiding this comment.
Following offline discussion, LGTM
|
LGTM |
darstahl
approved these changes
Sep 16, 2016
dcantah
pushed a commit
to dcantah/hcsshim
that referenced
this pull request
Mar 17, 2021
Refreshes the client code again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard jhoward@microsoft.com
Updates ConsoleSize to be a uint. This is part of the feedback from opencontainers/runtime-spec#563 (comment). It will require a minor tweak to docker once re-vendored.