Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile based on 0.70 + patch #121

Closed
wants to merge 1 commit into from

Conversation

aeulitz
Copy link

@aeulitz aeulitz commented Aug 16, 2022

Summary

Updating the version of ReactCommon used within hermes-win to include the fix for RNW:9662 (pushed to FB RN per PR:34342)

Test Plan

All *Tests.exe within the hermes-win projects succeed. This is change is requirement to merge a new test method into RNW (locally verified).

Microsoft Reviewers: Open in CodeFlow

@aeulitz aeulitz requested a review from a team as a code owner August 16, 2022 23:54
@aeulitz aeulitz closed this Aug 16, 2022
@aeulitz
Copy link
Author

aeulitz commented Aug 16, 2022

Need to undo duplication of changes to hermes.(h|cpp) introduced with Vladimir's change.

@aeulitz aeulitz deleted the UpdateReactCommon3 branch August 17, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant