Fix register_environment #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ant0nsc
approved these changes
Oct 20, 2021
| @@ -453,7 +454,7 @@ def test_create_python_environment( | |||
| def test_register_environment( | |||
| mock_workspace: mock.MagicMock, | |||
| mock_environment: mock.MagicMock, | |||
| caplog: CaptureFixture, | |||
| caplog: LogCaptureFixture, | |||
| ) -> None: | |||
| env_name = "an environment" | |||
| env_version = "an environment" | |||
There was a problem hiding this comment.
maybe env_version should be a differen string than env_name, so that we can detect mixups more easily?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix register_environment to return the correct environment object, and to register a new environment with the correct environment version if applicable