Fixing checkpoint downloader #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vale-salvatelli
commented
Dec 20, 2021
vale-salvatelli
commented
Dec 20, 2021
Shruthi42
reviewed
Dec 20, 2021
Shruthi42
reviewed
Dec 20, 2021
Shruthi42
approved these changes
Dec 21, 2021
| @@ -1046,6 +1053,7 @@ def get_run_file_names(run: Run, prefix: str = "") -> List[str]: | |||
| :return: A list of paths within the Run's container | |||
| """ | |||
| all_files = run.get_file_names() | |||
| print(f"Selecting files with prefix {prefix}") | |||
There was a problem hiding this comment.
Did you leave this print statement in by accident?
There was a problem hiding this comment.
No, I made it a bit nicer and left it on purpose - I found it's useful to know which prefix is used to select among run files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes to the class CheckpointDownloader to fix a bug with the hierarchies of the downloaded folders.