-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear Event Hub Device Watermarks when source event hub changed #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clear checkpoints stored in blob paths pertaining to older event hub
rogordon01
reviewed
Jun 18, 2021
src/lib/Microsoft.Health.Events/EventCheckpointing/StorageCheckpointClient.cs
Outdated
Show resolved
Hide resolved
src/lib/Microsoft.Health.Events/EventCheckpointing/StorageCheckpointClient.cs
Outdated
Show resolved
Hide resolved
namalu
approved these changes
Jun 18, 2021
src/lib/Microsoft.Health.Events/EventCheckpointing/StorageCheckpointClient.cs
Show resolved
Hide resolved
src/lib/Microsoft.Health.Events/EventCheckpointing/StorageCheckpointClient.cs
Show resolved
Hide resolved
dustinburson
requested changes
Jun 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
wi-y
reviewed
Jun 21, 2021
src/lib/Microsoft.Health.Events/EventCheckpointing/StorageCheckpointClient.cs
Outdated
Show resolved
Hide resolved
wi-y
approved these changes
Jun 22, 2021
dustinburson
approved these changes
Jun 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Added a few more suggestions.
src/lib/Microsoft.Health.Events/EventCheckpointing/StorageCheckpointClient.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description -
When customer changes their source of events (source event hub) the IoT Connector watermark should be reset and process all data available from the earliest available point in the event hub.
Changes -
Testing -
PENDING -
Once this change takes effect, the checkpoints in the older path will not be honored, which will trigger reprocessing of the data. To avoid this, we can copy over the older checkpoints to the new location. Dustin is helping gauge how many active Gen2 connectors we have and the size of data ingested, to assess the impact and take the call accordingly. Will not be closing this PR until then, but putting this out now for first pass of review.