Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return null when reference not in format of ResourceType/Identifier #119

Merged
merged 6 commits into from
Jul 7, 2021

Conversation

wi-y
Copy link
Contributor

@wi-y wi-y commented Jul 7, 2021

The previous pull request for GetId would return an empty string instead of null when the id contained query params in the form "Patient/123?_lastUpdated=gt2010-10-01". GetId should be returning null and not an empty string. Added a test and fixed the code.

@wi-y wi-y requested review from namalu and dustinburson July 7, 2021 23:01
@wi-y wi-y requested a review from a team as a code owner July 7, 2021 23:01
@wi-y wi-y merged commit 022b63d into master Jul 7, 2021
@dustinburson dustinburson deleted the personal/wiyochum/validate-patient-id-characters branch November 8, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants