Add correlation id as option for grouping measurements #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… query property of ARM templates * Add ability to extract correlation id to JsonPathContentTemplate * Add tests for extraction logic
…ationIdNotDefinedException with id not set * Add CorrelationIdNotDefinedException to telemetry processor as a known non-recoverable error. * Add unit tests for new observation groups and observation group factories.
LiquidPT
reviewed
Jun 11, 2020
...soft.Health.Fhir.Ingest.UnitTests/Data/CorrelationMeasurementObservationGroupFactoryTests.cs
Outdated
Show resolved
Hide resolved
…rval hasn't changed. This is to ensure no backwards breaking changes.
…at includes data to be created and information about the existing observation.
* Add ability to update the period of observation if the merged values our outside the current period. * Add unit tests for observation period update scenario.
…d period when merging data. Old period will now be used and tests updated. * Updated SampledDataFhirValueProcessor to use values from existing observation when merging sample data. Tests updated.
namalu
approved these changes
Jun 17, 2020
|
|
||
| public TimePeriodMeasurementObservationGroup((DateTime Start, DateTime End) boundary) | ||
| { | ||
| _bondary = boundary; |
There was a problem hiding this comment.
No, it is a value type, can never be null. The implicit tuple syntax i.e. ( , ) is compiled as a struct.
| correlationId = GetCorrelationId(token); | ||
| EnsureArg.IsNotNull(correlationId, nameof(correlationId)); | ||
| } | ||
|
|
||
| var measurement = new Measurement | ||
| { | ||
| DeviceId = deviceId, | ||
| OccurrenceTimeUtc = timestamp.Value, | ||
| Type = TypeName, | ||
| PatientId = GetPatientId(token), |
There was a problem hiding this comment.
Should we treat PatientId and EncounterId the same as CorrelationId? Where if there is an expression defined we require the value in the message?
There was a problem hiding this comment.
This was something I considered but it would change existing behavior. Right now the values will be normalized and then generate specific errors in the FHIR conversion side that will be logged in App Insights.
…ead of data period during create to future proof. Right now they would always be the same. * Fix issue in SampledDataProcessor were the last value was omitted from the stream if it was on the end boundary. Never hit before because the hourly and daily time periods would end on the time boundary - 1 ms.
wi-y
approved these changes
Jun 18, 2020
Added documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional correlation id for grouping measurements to create observations in FHIR.
When a template is set to the new ObservationPeriodInterval = CorrelationId all measurements for a given device, type, and correlation id will share the same observation in FHIR. This overrides the traditional time based grouping like hourly or daily.
In order to use the feature the device messages need to supply a correlation id that is then extracted with the via the CorrelationIdExpression property added to the Json & Iot templates.