Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure the project of common testing libraries #60

Merged
merged 3 commits into from
Aug 21, 2020
Merged

Restructure the project of common testing libraries #60

merged 3 commits into from
Aug 21, 2020

Conversation

ms-teli
Copy link
Contributor

@ms-teli ms-teli commented Aug 20, 2020 •
edited
Loading

  • Update the common package for providing testing utilities.
  • Downgrade the .net dependency to make the utility consumable by other project that depends on .net framework 4.8.
  • Remove incompatible dependency "xunit.runner.visualstudio" in the project.
  • Flip the IsPackable to pack the project in the nuget.

@ms-teli ms-teli marked this pull request as ready for review August 21, 2020 00:50
@ms-teli ms-teli requested review from wi-y and namalu August 21, 2020 00:50
@ms-teli ms-teli changed the title Flip the boolean for IsPackable. Restructure the project of common testing libraries Aug 21, 2020
@ms-teli ms-teli merged commit ce75797 into master Aug 21, 2020
@ms-teli ms-teli deleted the personal/teli/release-common-testing-code branch August 21, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wi-y wi-y wi-y approved these changes

@namalu namalu Awaiting requested review from namalu

@dustinburson dustinburson Awaiting requested review from dustinburson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ms-teli @dustinburson @wi-y