-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom auth option for event producer factory #92
Merged
wi-y
merged 8 commits into
master
from
personal/wiyochum/add-custom-auth-option-for-event-producer
Mar 8, 2021
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3b400d4
method to prefix metric name
wi-y 8449e3a
Merge branch 'master' of https://github.com/microsoft/iomt-fhir
wi-y ad66e1f
Merge branch 'master' of https://github.com/microsoft/iomt-fhir
wi-y e3e14f9
Merge branch 'master' of https://github.com/microsoft/iomt-fhir
wi-y 9e80cd0
Merge branch 'master' of https://github.com/microsoft/iomt-fhir
wi-y 1042649
support custom auth option for event producer, consolidate code
wi-y abccdcd
better error messages
wi-y 6b93325
address pr feedback
wi-y File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
src/lib/Microsoft.Health.Events/Common/EventHubFormatter.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
// ------------------------------------------------------------------------------------------------- | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT License (MIT). See LICENSE in the repo root for license information. | ||
// ------------------------------------------------------------------------------------------------- | ||
|
||
using System; | ||
using EnsureThat; | ||
|
||
namespace Microsoft.Health.Events.Common | ||
{ | ||
public static class EventHubFormatter | ||
{ | ||
public static string GetEventHubFQDN(string host) | ||
{ | ||
EnsureArg.IsNotEmptyOrWhiteSpace(host); | ||
|
||
if (Uri.IsWellFormedUriString(host, UriKind.Absolute)) | ||
{ | ||
var uri = new Uri(host); | ||
host = uri.Host; | ||
} | ||
|
||
if (Uri.CheckHostName(host) != UriHostNameType.Unknown) | ||
{ | ||
return host; | ||
} | ||
else | ||
{ | ||
throw new Exception($"The event hub FQDN: {host} is not valid"); | ||
} | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, I personal prefer put validations first and let it fail as early as possible.
e.g.
if (!Uri.IsWellFormedUriString(host, UriKind.Absolute)) {
throw new Exception("not well formatted.");
}
var uri = new Uri(host);
host = uri.Host;
if(Uri.CheckHostName(host) == UriHostNameType.Unknown)
throw new Exception("host is unknown");
)
return host;