Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support uri in Source.path #58

Merged
merged 2 commits into from
Oct 12, 2017
Merged

Support uri in Source.path #58

merged 2 commits into from
Oct 12, 2017

Conversation

testforstephen
Copy link
Contributor

Signed-off-by: Jinbo Wang jinbwan@microsoft.com

This feature will also resolve these bugs:
#24
microsoft/vscode-java-debug#46
microsoft/vscode-java-debug#21

Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
@msftclas
Copy link

@testforstephen,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@testforstephen
Copy link
Contributor Author

Hold on first. Need wait the change for this bug microsoft/vscode#30996 is ready on the official vscode.

@testforstephen testforstephen changed the title [Don't Merge] Support uri in Source.path Support uri in Source.path Oct 12, 2017
@@ -151,6 +153,19 @@ public static String toUri(String path) {
}

/**
* Check a string variable is an uri or not.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an ==> a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants