Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to control MaxMatchesCount for Ask via IContext #860

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

westdavidr
Copy link
Contributor

@westdavidr westdavidr commented Oct 23, 2024

Motivation and Context (Why the change? What's the scenario?)

Need the ability to control the MaxMatchesCount per Ask request instead of always defaulting to the configuration value.

High level description (Approach, Design)

Add MaxMatchesCount constant and extensions.

@westdavidr westdavidr requested a review from dluc as a code owner October 23, 2024 15:31
@westdavidr
Copy link
Contributor Author

@dluc Let me know what you think of this. I have a need to control the max matches per request (generally per index, but that's controlled from the client logic) when using the /Ask endpoint.

Copy link
Collaborator

@dluc dluc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dluc dluc merged commit 6c6f04d into microsoft:main Oct 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants