Refactor DataPipelineStatus and DataPipeline classes #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the `Failed` property from `DataPipelineStatus` and reordered the `Empty` property with `JsonPropertyOrder` of 1. Updated `DataPipeline` class: refactored `Log` method to use null-coalescing assignment and adjusted `ToDataPipelineStatus` method to reflect the removal of the `Failed` property.
dluc
reviewed
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the
Failedproperty fromDataPipelineStatusand reordered theEmptyproperty withJsonPropertyOrderof 1. UpdatedDataPipelineclass: refactoredLogmethod to use null-coalescing assignment and adjustedToDataPipelineStatusmethod to reflect the removal of theFailedproperty.Motivation and Context (Why the change? What's the scenario?)
See #709