- fixes array of numbers serialization for url template parameters

microsoft · Feb 1, 2024 · d93edae · d93edae
1 parent fcf9d68
commit d93edae
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/Microsoft.Kiota.Abstractions.Tests/RequestInformationTests.cs b/Microsoft.Kiota.Abstractions.Tests/RequestInformationTests.cs
@@ -529,7 +529,7 @@ public void SetsIntValuesInQueryParameters()
                 UrlTemplate = "http://localhost/me{?items}"
             };
             // Act
-            requestInfo.AddQueryParameters(new GetQueryParameters { Items = new object []{1,2}});
+            requestInfo.AddQueryParameters(new GetQueryParameters { Items = new object[] { 1, 2 } });
             // Assert
             Assert.Equal("http://localhost/me?items=1,2", requestInfo.URI.ToString());
         }
@@ -544,15 +544,15 @@ public void SetsBooleanValuesInQueryParameters()
                 UrlTemplate = "http://localhost/me{?items}"
             };
             // Act
-            requestInfo.AddQueryParameters(new GetQueryParameters { Items = new  object [] { true, false } });
+            requestInfo.AddQueryParameters(new GetQueryParameters { Items = new object[] { true, false } });
             // Assert
             Assert.Equal("http://localhost/me?items=true,false", requestInfo.URI.ToString());
         }
 
         [Fact]
         public void SetsDateTimeOffsetValuesInQueryParameters()
         {
-           var requestInfo = new RequestInformation
+            var requestInfo = new RequestInformation
             {
                 HttpMethod = Method.GET,
                 UrlTemplate = "http://localhost/me{?items}"
@@ -615,7 +615,7 @@ public void SetsTimeValuesInQueryParameters()
             };
 
             // Act
-            var date1 = new Time(10,0,0);
+            var date1 = new Time(10, 0, 0);
             var date2 = new Time(11, 1, 1);
 
             requestInfo.AddQueryParameters(new GetQueryParameters { Items = new object[] { date1, date2 } });
@@ -654,15 +654,15 @@ public void DoesNotExpandSecondLayerArrays()
             };
 
             // Act
-            requestInfo.AddQueryParameters(new GetQueryParameters { Items = new object[]{new int[]{1,2,3,4} } });
+            requestInfo.AddQueryParameters(new GetQueryParameters { Items = [new int[] { 1, 2, 3, 4 }] });
             // Assert
-            Assert.Equal("http://localhost/me?items=System.Int32%5B%5D", requestInfo.URI.OriginalString);
+            Assert.Throws<ArgumentException>(() => requestInfo.URI.OriginalString);
         }
 
 
     }
 
-    
+
 
     /// <summary>The messages in a mailbox or folder. Read-only. Nullable.</summary>
     internal class GetQueryParameters

diff --git a/src/RequestInformation.cs b/src/RequestInformation.cs
@@ -172,12 +172,12 @@ public void AddQueryParameters<T>(T source)
             }
         }
 
-        private static string[] ExpandArray(Array collection)
+        private static object[] ExpandArray(Array collection)
         {
-            var passedArray = new string[collection.Length];
+            var passedArray = new object[collection.Length];
             for(var i = 0; i < collection.Length; i++)
             {
-                passedArray[i] = GetSanitizedValue(collection.GetValue(i)!).ToString()!;
+                passedArray[i] = GetSanitizedValue(collection.GetValue(i)!);
             }
             return passedArray;
         }
@@ -188,7 +188,7 @@ private static object ReplaceEnumValueByStringRepresentation(object source)
             {
                 return enumValueName;
             }
-            
+
             return source;
         }
 #if NET5_0_OR_GREATER