Fix malformed multipart body #1423
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shemogumbe
had a problem deploying
to
build_test
GitHub Actions
Failure
shemogumbe
had a problem deploying
to
build_test
GitHub Actions
Failure
…iota-typescript into fix_malformed_multipart_body
shemogumbe
had a problem deploying
to
build_test
GitHub Actions
Failure
shemogumbe
had a problem deploying
to
build_test
GitHub Actions
Failure
shemogumbe
had a problem deploying
to
build_test
GitHub Actions
Failure
shemogumbe
had a problem deploying
to
build_test
GitHub Actions
Failure
shemogumbe
had a problem deploying
to
build_test
GitHub Actions
Failure
shemogumbe
had a problem deploying
to
build_test
GitHub Actions
Failure
shemogumbe
had a problem deploying
to
build_test
GitHub Actions
Failure
shemogumbe
had a problem deploying
to
build_test
GitHub Actions
Failure
shemogumbe
had a problem deploying
to
build_test
GitHub Actions
Failure
shemogumbe
had a problem deploying
to
build_test
GitHub Actions
Failure
baywet
requested changes
Oct 16, 2024
| @@ -93,7 +93,7 @@ interface MultipartEntry { | |||
| serializationCallback?: ModelSerializerFunction<Parsable>; | |||
| } | |||
|
|
|||
| export const serializeMultipartBody = (writer: SerializationWriter, multipartBody: Partial<MultipartBody> | undefined | null = new MultipartBody()): void => { | |||
There was a problem hiding this comment.
please revert the const changes on this line. Here is more context https://www.freecodecamp.org/news/the-difference-between-arrow-functions-and-normal-functions/
| @@ -30,51 +30,48 @@ export class MultipartSerializationWriter implements SerializationWriter { | |||
| public onBeforeObjectSerialization: ((value: Parsable) => void) | undefined; | |||
| public onAfterObjectSerialization: ((value: Parsable) => void) | undefined; | |||
| public onStartObjectSerialization: ((value: Parsable, writer: SerializationWriter) => void) | undefined; | |||
| public writeStringValue = (key?: string, value?: string | null): void => { | |||
| public writeStringValue = (key?: string, value?: string): void => { | |||
There was a problem hiding this comment.
please revert the removal of null here as it does not conform with the interface
| } | ||
| }; | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| public writeBooleanValue = (key?: string, value?: boolean | null): void => { | ||
| public writeBooleanValue = (key?: string, value?: boolean): void => { |
There was a problem hiding this comment.
same comment about the null option for all the following methods
| if (first) { | ||
| first = false; | ||
| } else { | ||
| writer.writeStringValue(undefined, ""); | ||
| writer.writeStringValue(undefined, "\r\n"); |
There was a problem hiding this comment.
can we add a unit test to prevent future regressions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened to replace #1069 which seems to be from a fork I can't access
Fixes #1068