-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up lerna and add test infrastructure #72
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
reviewed
Apr 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for starting this. a couple of comments/questions
baywet
reviewed
Apr 11, 2022
baywet
previously approved these changes
Apr 19, 2022
* - adds support for mapping query parameter names Signed-off-by: Vincent Biret <vibiret@microsoft.com> * - adds parameters name decoding middleware Signed-off-by: Vincent Biret <vibiret@microsoft.com> * - fixes test data Signed-off-by: Vincent Biret <vibiret@microsoft.com> * - updates unit test for PR feedback Signed-off-by: Vincent Biret <vibiret@microsoft.com> * - adds an integration test for parameters encoding Signed-off-by: Vincent Biret <vibiret@microsoft.com> * - fixes query parameters unit test after middleware move Signed-off-by: Vincent Biret <vibiret@microsoft.com> * - adds missing exports for parameters middleware Signed-off-by: Vincent Biret <vibiret@microsoft.com> * - fixes factory tests after the addition of prameters names decoding middleware Signed-off-by: Vincent Biret <vibiret@microsoft.com>
baywet
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2
fixes #65