Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip deploy job when package version has not been increased #211

Closed
8 tasks
baywet opened this issue Jun 4, 2021 · 4 comments
Closed
8 tasks

skip deploy job when package version has not been increased #211

baywet opened this issue Jun 4, 2021 · 4 comments
Labels
Csharp Pull requests that update .net code enhancement New feature or request hacktoberfest help wanted Issue caused by core project dependency modules or library Java Ruby TypeScript Pull requests that update Javascript code

Comments

@baywet
Copy link
Member

baywet commented Jun 4, 2021

All the packages workflows currently have a similar issue for the deploy job: if the version hasn't been bumped, it will fail as conflicting during the deployment phase.
The list of workflows includes all workflows starting with abstractions-, authentication-, serialization- and http-.

Here is what we need:

  • 3 new powershell scripts in the "scripts" folder.
  • each script will take a path, a package name, and a feed url as mandatory parameters.
  • each script will be dedicated to one package ecosystem (npm, nuget, maven).
  • each script will get the latest version of the package on the feed for the given package name
  • each script will get the version of the package in the package path that's been provided
  • each script will compare the two versions and set a workflow variable indicating whether the package versions on the feed and in the package file are identical or not
  • workflows deploy job will be updated to call that the corresponding version check script with corresponding parameters
  • subsequent steps need a condition to execute only if the value has changed
    AB#9755
@baywet baywet added enhancement New feature or request help wanted Issue caused by core project dependency modules or library labels Jun 4, 2021
@baywet baywet added this to the Alpha milestone Jun 4, 2021
@baywet
Copy link
Member Author

baywet commented Jun 4, 2021

@wcontayon do you feel like you could take on this one? are the instructions I put together clear enough?

@wcontayon
Copy link

@baywet, I can try a PR on it. It'll improve my scripting knowledge 🙂 🙂

@baywet
Copy link
Member Author

baywet commented Jun 4, 2021

Thanks! Assigning to you. Don't hesitate if you have questions.

@baywet baywet linked a pull request Jun 14, 2021 that will close this issue
7 tasks
@baywet baywet modified the milestones: Alpha, Beta Jul 14, 2021
@baywet baywet added Csharp Pull requests that update .net code Java Ruby TypeScript Pull requests that update Javascript code labels Jul 21, 2021
@baywet baywet modified the milestones: Beta, SDK subset support Sep 17, 2021
@baywet
Copy link
Member Author

baywet commented May 30, 2022

Closing this as we're moving the kiota packages for each language to their own repo and it will be the responsibility of the dedicated repo to handle that depending on the deployment workflow.

@baywet baywet closed this as completed May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Csharp Pull requests that update .net code enhancement New feature or request hacktoberfest help wanted Issue caused by core project dependency modules or library Java Ruby TypeScript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants