Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default client name GraphClient => ApiClient #199

Merged
merged 3 commits into from
Jun 3, 2021
Merged

Change default client name GraphClient => ApiClient #199

merged 3 commits into from
Jun 3, 2021

Conversation

wcontayon
Copy link

Adresses #189

baywet
baywet reviewed Jun 2, 2021
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wcontayon thanks a lot for your contribution!

baywet
baywet previously approved these changes Jun 2, 2021
View reviewed changes
@baywet baywet added this to the Alpha milestone Jun 2, 2021
@baywet baywet self-assigned this Jun 2, 2021
@baywet baywet linked an issue Jun 2, 2021 that may be closed by this pull request
Change the default client name from GraphClient to ApiClient #189
Closed
@baywet baywet enabled auto-merge June 2, 2021 10:44
@wcontayon
Copy link
Author

@wcontayon thanks a lot for your contribution!

You're welcome @baywet. Please feel free to assigne me some interesting issues. It's a pleasure to contribute on Microsoft Open Source project. 🙂 🙂 🙂

peombwa
peombwa previously approved these changes Jun 2, 2021
View reviewed changes
@baywet baywet dismissed stale reviews from peombwa and themself via 4f5cdf9 June 3, 2021 12:17
@ghost
Copy link

ghost commented Jun 3, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@baywet
Copy link
Member

baywet commented Jun 3, 2021

@wcontayon can you sign the CLA please before we can merge this PR? (see the previous message from the bot)

@baywet baywet merged commit a8a7c56 into microsoft:main Jun 3, 2021
@baywet
Copy link
Member

baywet commented Jun 3, 2021

@wcontayon thanks! your pull request has now been merged. Congrats!

We're more than happy to have you contributing, just so I can gage what kind of work items I can assign you, how much time are you looking at spending on the project? Do you know any language we could add, like PHP or Go?

@wcontayon
Copy link
Author

@baywet I've some knowledge (not an expert) on PHP, but not in Go.
I mainly work with .NET. Feel free to assign me .NET issues (help, bug, enhancement) 🙂

@baywet
Copy link
Member

baywet commented Jun 4, 2021

great! have a look at #135 and #211 and tell me if you feel like taking any of those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@peombwa peombwa peombwa left review comments

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@nikithauc nikithauc Awaiting requested review from nikithauc

@zengin zengin Awaiting requested review from zengin

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
Alpha
Development

Successfully merging this pull request may close these issues.

Change the default client name from GraphClient to ApiClient
3 participants
@wcontayon @baywet @peombwa