Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for request option generation and middleware configuration in ruby #446

Closed
5 tasks
baywet opened this issue Aug 4, 2021 · 2 comments
Closed
5 tasks

Add support for request option generation and middleware configuration in ruby #446

baywet opened this issue Aug 4, 2021 · 2 comments
Labels
enhancement New feature or request hacktoberfest help wanted Issue caused by core project dependency modules or library Ruby
Milestone
Complete Graph AP...

Comments

@baywet
Copy link
Member

baywet commented Aug 4, 2021 •
edited
Loading

After merging #330 ruby generation will generate inaccurate clients as it was built without the middleware options in mind.

TODO

  • add a request option interface in the abstractions
  • add a options collection, addrequestoptions and get requestptions on request info
  • update generation to add the options to the request in the request generator methods
  • update generation to pass the options from the request executor to the generator
  • add a middleware infrastructure and a way to get the defaults in the http library (depends on http core for ruby #419)
    AB#10516
@baywet baywet added enhancement New feature or request Ruby labels Aug 4, 2021
@baywet baywet added this to the GA milestone Aug 4, 2021
@baywet baywet added the help wanted Issue caused by core project dependency modules or library label Aug 11, 2021
@baywet baywet changed the title Add support for middleware generation and configuration in ruby Add support for request option generation and middleware configuration in ruby Oct 1, 2021
@baywet
Copy link
Member Author

baywet commented Oct 1, 2021

related #635

@baywet
Copy link
Member Author

baywet commented Jun 23, 2022

closing as duplicate of #1650

@baywet baywet closed this as completed Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest help wanted Issue caused by core project dependency modules or library Ruby
Projects
None yet
Milestone
Complete Graph API Surface support
Development

No branches or pull requests
2 participants
@baywet @abfarah