Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename IMiddlewareOption to IRequestOption #635

Closed
Tracked by #1049
darrelmiller opened this issue Sep 17, 2021 · 2 comments · Fixed by #676
Closed
Tracked by #1049

Rename IMiddlewareOption to IRequestOption #635

darrelmiller opened this issue Sep 17, 2021 · 2 comments · Fixed by #676
Assignees
@baywet
Labels
Csharp Pull requests that update .net code enhancement New feature or request fixed generator Issues or improvements relater to generation capabilities. Go Java TypeScript Pull requests that update Javascript code
Milestone
TypeWriter Replac...

Comments

@darrelmiller
Copy link
Member

darrelmiller commented Sep 17, 2021 •
edited by azure-boards bot
Loading

To avoid leaking implementation details of HttpCore we want to focus on the fact that these are "per request" options. Whether they happen to be implemented as middleware or not isn't relevant to the user.
AB#11170
@baywet baywet added this to the Beta milestone Sep 17, 2021
@baywet baywet self-assigned this Sep 17, 2021
@baywet baywet added Csharp Pull requests that update .net code enhancement New feature or request generator Issues or improvements relater to generation capabilities. Go Java TypeScript Pull requests that update Javascript code Ruby labels Sep 17, 2021
@nikithauc
Copy link
Contributor

Does this mean that IMiddlewareOption will move to the core?

@baywet
Copy link
Member

baywet commented Sep 20, 2021

No because the generated results rely on that interface. And the generation result should only depend on the abstractions package.

@baywet baywet mentioned this issue Oct 1, 2021
Closed
5 tasks
@baywet baywet removed the Ruby label Oct 1, 2021
baywet added a commit that referenced this issue Oct 1, 2021
@baywet
- fixes #635 Renames middlewareoption into requestoption to stay agno…
b4a9aac 
…stic from implementation
@baywet baywet mentioned this issue Oct 1, 2021
Merged
@baywet baywet linked a pull request Oct 1, 2021 that will close this issue
aligns naming conventions across packages #676
Merged
@baywet baywet added the fixed label Oct 1, 2021
baywet added a commit that referenced this issue Oct 4, 2021
@baywet
- fixes #635 Renames middlewareoption into requestoption to stay agno…
ad45a65 
…stic from implementation
@baywet baywet mentioned this issue Jan 21, 2022
Closed
42 tasks
@baywet baywet mentioned this issue Jun 23, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baywet baywet

Labels
Csharp Pull requests that update .net code enhancement New feature or request fixed generator Issues or improvements relater to generation capabilities. Go Java TypeScript Pull requests that update Javascript code
Projects
None yet
Milestone
TypeWriter Replacement
Development

Successfully merging a pull request may close this issue.

aligns naming conventions across packages microsoft/kiota
3 participants
@darrelmiller @baywet @nikithauc