Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Kiota search apicurio #3670

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

andreaTP
Copy link
Contributor

@andreaTP andreaTP commented Nov 6, 2023

This is an initial(wip) integration of Apicurio as a search provider for Kiota.
It was briefly discussed with @baywet during the community meeting last time.

This implementation already "works"(against unauthenticated instances) but I think we need a little more to get it in a usable state:

  • command line configuration options

kiota search --help doesn't show the specific configurations (i.e. same for github) and passing those seems to be a bit tricky, or, at least, you should know about appsettings etc..
With Apicurio Registry we need to pass a few options and they should be easily discoverable by the users, I'm looking for proposals on how to design this (no super strong C# dev skills here 😊 ).

  • authentication providers

Often Apicurio Registry instances are protected with Oidc Authentication, we need slightly better integration (as mentioned here ) to get this streamlined.
I'll go ahead and propose something in kiota-java that I will eventually port to dotnet.

@andreaTP
Copy link
Contributor Author

andreaTP commented Nov 6, 2023

cc. @EricWittmann @paoloantinori

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a really good start! And I'm happy to see another kiota client in kiota too, full circle 🥳
For what I suggest we call "user configuration" (configuration that is likely to vary a lot on a per user base), have a look at the "login github" command. The design here was intended to support private GitHub enterprise instances over time.
The main change I'd make though is for some reason that configuration is stored in TEMP/TMP when it should be stored in AppData instead.

Co-authored-by: Vincent Biret <vibiret@microsoft.com>
@andreaTP
Copy link
Contributor Author

andreaTP commented Nov 7, 2023

I'm happy to see another kiota client in kiota too, full circle 🥳

Yup! Super nice :-)
Have you considered shipping Kiota as a Source Generator library?
In this way, you might be able to directly reuse Kiota from sources(as opposed to using the CLI), increasing the chances of catching bugs early and avoiding committing the generated code.

have a look at the "login github" command.

I'll try to figure something out, will get back if I get stuck, thanks! 👍

@baywet
Copy link
Member

baywet commented Nov 7, 2023

Have you considered shipping Kiota as a Source Generator library?

Source generators have lots of serious limitations and odd behaviours at the moment, we're purposefully staying away from them for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo 📃
Development

Successfully merging this pull request may close these issues.

2 participants