Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Update plugin type on to accept multiple values #4917

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Fix: Update plugin type on to accept multiple values #4917

merged 1 commit into from
Jul 2, 2024

Conversation

ElinorW
Copy link
Contributor

@ElinorW ElinorW commented Jul 1, 2024

Fixes #4870

This PR updates the generation and re-generation functions to accept an array of plugin types.

Steps to test

  1. Load extension
  2. Open an API description and select endpoints
  3. Generate a plugin
  4. Open workspace.json and edit the plugin type, save, then click re-generate on the file.
  5. Observe fix

@ElinorW ElinorW requested a review from a team as a code owner July 1, 2024 19:21
@ElinorW ElinorW linked an issue Jul 1, 2024 that may be closed by this pull request
When editing the workspace.json and clicking on re-generate, the API client/ API plugin should be regenerated successfully #4870
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@baywet baywet merged commit b38066e into elinor/add-kiota-workspace Jul 2, 2024
204 checks passed
@baywet baywet deleted the elinor/multiple-plugin-support branch July 2, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ElinorW @andrueastman @baywet