Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vs-Code functionality to generate http snippets #5268

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

koros
Copy link
Contributor

@koros koros commented Aug 29, 2024

No description provided.

@koros koros added the draft label Aug 29, 2024
@koros koros requested a review from a team as a code owner August 29, 2024 08:15
@koros koros marked this pull request as draft August 29, 2024 08:15
@@ -242,6 +243,77 @@ export async function activate(
}
}
),
registerCommandWithTelemetry(reporter,
`${treeViewId}.generateHttpSnippet`,
async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is new code, and there's planned refactoring, it would be safe to move the functionality of this command out of the extension.ts file.

The command can follow the abstract command class as defined in this PR #5160

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thewahome I can wait for yours to get merged first to avoid increasing the conflict delta, if we both refactor at the same time, the conflict will be greater down the line

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is likely not going to get merged because of how much the code has changed since freezing it. It's going to be maintained as a reference.

Copy link

sonarcloud bot commented Oct 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
68.2% Coverage on New Code (required ≥ 80%)
7.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants