Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed GeneratedCode attribute applied when generating CSharp to only include the major version of Kiota #5573

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Changed GeneratedCode attribute applied when generating CSharp to only include the major version of Kiota #5573

merged 2 commits into from
Oct 10, 2024

Conversation

Balkoth
Copy link
Contributor

@Balkoth Balkoth commented Oct 10, 2024

Now only the major version of Kiota is written to the GeneratedCode attribute when generating the CSharp client.

Example:
Kiota Version 1.19.0
[global::System.CodeDom.Compiler.GeneratedCode("Kiota", "1.0.0")]

Fixes #5489

@Balkoth Balkoth requested a review from a team as a code owner October 10, 2024 07:53
baywet
baywet approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@baywet baywet enabled auto-merge October 10, 2024 17:44
@baywet baywet merged commit c64eab8 into microsoft:main Oct 10, 2024
209 checks passed
@Balkoth Balkoth deleted the genMajorVersion branch October 11, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File-diff between versions is impossible after GeneratedCode attribute with version is applied
2 participants
@Balkoth @baywet