-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove stringify from primitive types #5616
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd also need a changelog entry for this as well...
Quality Gate passedIssues Measures |
@@ -25,6 +25,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
- Fixed cyclic dependencies in generated Go code. [#2834](https://github.com/microsoft/kiota/issues/2834) | |||
- Fixed a bug where default output folder is created on plugin edit and generate commands. [#5510](https://github.com/microsoft/kiota/issues/5429) | |||
- Changed GeneratedCode attribute applied when generating CSharp to only include the major version of Kiota. [#5489](https://github.com/microsoft/kiota/issues/5489) | |||
- Fixed genarating CSharp client displays clean hint regardless of whether --clean-output is already passed [#5576](https://github.com/microsoft/kiota/issues/5576) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be moved to the unreleased section
@@ -806,7 +806,8 @@ private string GetSerializationMethodName(CodeTypeBase propType) | |||
private string GetTypeFactory(bool isVoid, bool isStream, string returnType) | |||
{ | |||
if (isVoid) return string.Empty; | |||
if (isStream || conventions.IsPrimitiveType(returnType)) return $" \"{returnType}\","; | |||
if (isStream || conventions.IsPrimitiveType(returnType)) return $" {returnType},"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we update/add a unit test for this so we prevent future regressions?
Fixes #5417
From
To
Note - the param type was fixed in an earlier PR for a related issue in September