Update requirements #285
Merged
Update requirements #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
commented
Jul 10, 2024
| @@ -464,8 +464,7 @@ def _layout_items(items): | |||
| 'line_len': line_len | |||
| } | |||
| layout['summary'] = layout['summary'].replace('\n', ' ') | |||
| if line_len > self.max_line_len: | |||
| self.max_line_len = line_len | |||
| self.max_line_len = max(line_len, self.max_line_len) | |||
There was a problem hiding this comment.
To solve pylint error:
> pylint knack --rcfile=.pylintrc --reports n --disable I0013
************* Module knack.help
knack\help.py:467:16: R1731: Consider using 'max_line_len = max(max_line_len, line_len)' instead of unnecessary if block (consider-using-max-builtin)
knack\help.py:589:16: R1731: Consider using 'max_line_len = max(max_line_len, line_len)' instead of unnecessary if block (consider-using-max-builtin)
bebound
approved these changes
Jul 11, 2024
jiasli
force-pushed
the
update-requirements
branch
from
41f20ff
to
e5180b8
Compare
bebound
approved these changes
Jul 12, 2024
evelyn-ys
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update requirements to make sure all latest dependencies work with Python 3.12 (#279).