-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to dynamically register semantic tokens #1107
Comments
The idea is to have only one registration. This is why Does that make sense? |
It does, but then how should semantic tokens be registered? |
Good find. This is actually more a bug in VS Codes implementation which happened when I renamed the requests. Let me have a look there. |
I fixed this in the LSP libraries. In the upcoming next version you can register using |
cc @gundermanc just so you're aware, this will affect the visual studio language client. |
What's the change exactly? AFAIK VS IDE does not yet support dynamic registration of capabilities. |
@gundermanc it only affects dynamic registration. The routes to request semantic tokens are still the same. |
This includes the fix for microsoft/language-server-protocol#1107. We need this merged in order to resolve golang/go#42148. Change-Id: I675b20f24019f590f8c3dbb4257c8414d282de98 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/266497 Trust: Rebecca Stambler <rstambler@golang.org> Trust: Suzy Mueller <suzmue@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Suzy Mueller <suzmue@golang.org> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
I have a few questions about dynamic registration for the semantic tokens methods.
textDocument/semanticTokens/full
,textDocument/semanticTokens/full/delta
, andtextDocument/semanticTokens/range
, I get errors fortextDocument/semanticTokens/full/delta
andtextDocument/semanticTokens/range
.SemanticTokensOptions
? Shouldfull
andrange
be configured in those options or left out since they are registered individually?The text was updated successfully, but these errors were encountered: