Introduce lower bound on attrs
version
#179
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lsprotocol
uses theimport attrs
API which was only introduced inv21.3.0
.This PR sets a minimum version for attrs in the python package's
pyproject.toml
to hopefully guard against issues like this one in the future.Question: Is it sufficient to rely on the version bound set here to ensure the correct version is also installed for
pygls
andesbonio
? Or since both downstream packages alsoimport attrs
themselves, is it more correct to have a version bound set in bothpygls
andesbonio
? 🤔