Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce lower bound on attrs version #179

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

alcarney
Copy link
Contributor

@alcarney alcarney commented Mar 6, 2023

lsprotocol uses the import attrs API which was only introduced in v21.3.0 .

This PR sets a minimum version for attrs in the python package's pyproject.toml to hopefully guard against issues like this one in the future.

Question: Is it sufficient to rely on the version bound set here to ensure the correct version is also installed for pygls and esbonio? Or since both downstream packages also import attrs themselves, is it more correct to have a version bound set in both pygls and esbonio? 🤔

`import attrs` is only available in versions 21.3.0 and newer
@karthiknadig karthiknadig self-assigned this Mar 6, 2023
@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Mar 6, 2023
@brettcannon
Copy link
Member

Question: Is it sufficient to rely on the version bound set here to ensure the correct version is also installed for pygls and esbonio?

Yes, as your installer's resolver will have to make sure that any version of a distribution that gets installed is compatible with all requirements for that distribution. Basically pip has to walk the dependency graph and make sure whatever it chooses to install for attrs satisfies every requirement it comes across.

@karthiknadig karthiknadig merged commit 5778454 into microsoft:main Mar 6, 2023
@alcarney alcarney deleted the attrs-min-bound branch March 6, 2023 22:05
@alcarney
Copy link
Contributor Author

alcarney commented Mar 6, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants