move tests to their packages directory #360
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
| @@ -35,7 +35,7 @@ Issues = "https://github.com/microsoft/lsprotocol/issues" | |||
| Source = "https://github.com/microsoft/lsprotocol" | |||
|
|
|||
| [tool.flit.sdist] | |||
| include = ["lsprotocol/", "README.md", "LICENSE"] | |||
| include = ["lsprotocol/", "tests/", "README.md", "LICENSE"] | |||
There was a problem hiding this comment.
@T-256 Do you recommend including tests in the package? It will be incomplete as the generated test data, won't be part of it. It will get testing of special cases, if tests are run only with this package.
There was a problem hiding this comment.
Do you recommend including tests in the package?
motivations here are same as other these python packages:
encode/httpx#2927
encode/httpcore#799
An usecase would be for package-indexing managers want to able test packages from sdist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.