Use stable name generation from LSP spec #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthiknadig
changed the title
eleanorjboyd
approved these changes
Jul 31, 2024
| if request.params: | ||
| if ( | ||
| request.params.kind == "reference" | ||
| and f"{class_name}Params" in CUSTOM_REQUEST_PARAMS_ALIASES | ||
| and {params_class_name} in CUSTOM_REQUEST_PARAMS_ALIASES |
There was a problem hiding this comment.
is the curly brackets what you want here? All the other ones for this line removed those, just wanted to check
| @@ -1115,6 +1116,22 @@ def _completion_item_kind_hook( | |||
| Union[lsp_types.CompletionItemKind, int], | |||
| _completion_item_kind_hook, | |||
| ), | |||
| ( | |||
| Optional[Union[str, lsp_types.RelativePattern]], | |||
There was a problem hiding this comment.
Are you planning on switching to using the | operator? Or is there a preference for Union here? Not sure the python version for this repo either
There was a problem hiding this comment.
We can make the change after this commit. As it will be a huge change.
karthiknadig
added a commit
to karthiknadig/lsprotocol
that referenced
this pull request
Aug 7, 2024
karthiknadig
added a commit
that referenced
this pull request
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #364