Fix character decoding issues with text-like files #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
brc-dd
force-pushed
the
fix/18
branch
2 times, most recently
from
d44f35f to
112c276
Compare
|
@brc-dd can you please expand the tests? Or at least share an example csv with this error? |
|
Updated the tests. |
|
Can you please run the pre-commit checks? I think it should be |
|
Formatted. |
gagb
approved these changes
Dec 15, 2024
brc-dd
commented
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18
Non utf-8 html pages are still not supported. It will need detecting language from content-type header or meta tags like
<meta charset="utf-8" />or<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />. And at last fall back to auto detecting.Bing, WikiPedia and Youtube converters don't need this as they always have utf-8 encoding.