Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First check in of TabView #629

Merged
merged 11 commits into from
Jun 3, 2019
Merged

First check in of TabView #629

merged 11 commits into from
Jun 3, 2019

Conversation

teaP
Copy link
Contributor

@teaP teaP commented Apr 29, 2019

TabView's current features are mostly drawn from the toolkit version. Names are not final; this is just a preliminary checkin to match the features given to Terminal for Build. For a list of things not in it currently (noteably, any accessibility work) check out the feature issue: #590

I discovered that accessibility tools cannot see anything, at all, inside the actual tab content. Huge problem that I haven't been able to fix yet. If anyone has any ideas, please let me know...

@teaP teaP requested a review from a team April 29, 2019 18:28
@mdtauk
Copy link
Contributor

mdtauk commented Apr 29, 2019

Maybe an idea for the ToDo list. Tab Placement? Bottom, Left, Right.

dev/TabView/TabView.h Outdated Show resolved Hide resolved
dev/TabView/TabView.h Outdated Show resolved Hide resolved
$controlDir = $muxControlsDir + "\dev\$projectName"

# TODO: check if project directory exists

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test-Path ? or is this TODO more about "what should we do if it exists already?"

idl/Microsoft.UI.Xaml.idl Outdated Show resolved Hide resolved
dev/TabView/TabView.idl Outdated Show resolved Hide resolved
dev/TabView/TabView.cpp Outdated Show resolved Hide resolved
dev/TabView/TabView.cpp Outdated Show resolved Hide resolved
dev/TabView/TabView.cpp Outdated Show resolved Hide resolved
Copy link
Member

@jevansaks jevansaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some feedback, but nothing blocking. Can be addressed in a follow-up.

@teaP teaP merged commit cb63cf5 into master Jun 3, 2019
@jevansaks jevansaks added feature proposal New feature proposal release note PR that we want to call out in the next release summary labels Jun 10, 2019
@msft-github-bot
Copy link
Collaborator

🎉Microsoft.UI.Xaml v2.2.190611001 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature proposal New feature proposal release note PR that we want to call out in the next release summary
Projects
None yet
Development

Successfully merging this pull request may close these issues.