Skip to content
This repository has been archived by the owner on Jun 10, 2022. It is now read-only.

Reorganize file structure, consolidate imports #482

Merged
merged 6 commits into from
Feb 13, 2020

Conversation

stevenvergenz
Copy link
Contributor

  • Reorganize the src folder's contents, breaking up the giant types folder by topic. The new folder structure looks like this:
    • src/actor - For the actor classes and all their components. Some component types are complicated enough to justify their own subfolders (i.e. physics).
    • src/animation - For the animation types.
    • src/asset - For the asset classes.
    • src/core - For system-level classes that still need to be exposed to the user (i.e. Context).
    • src/math - For all the math types.
    • src/user - For the handful of user classes.
    • src/util - For miscellaneous types that need to be exported (WebHost, Guid, log).
    • src/internal - For all types that are not exported. This includes all the networking types, adapters, and a raft of utility functions. Note: there are some "internal" types not in this folder (e.g. ActorInternal), which live in the folder that matches their exposed class. These are still not exposed.
  • Consolidate import statements in all files to pull from the src and src/internal directories instead of from individual files/folders.

@eanders-ms
Copy link
Contributor

I noticed the adapters are under "internal". We should publish the adapters. WebHost won't be appropriate for everyone.

@eanders-ms
Copy link
Contributor

I like the new layout!

@stevenvergenz
Copy link
Contributor Author

Seems reaosnable. Which classes? Just MultipeerAdapter and WebsocketAdapter?


In reply to: 584927450 [](ancestors = 584927450)

@eanders-ms
Copy link
Contributor

Yep those are the only adapters.


In reply to: 584936881 [](ancestors = 584936881,584927450)

Copy link
Contributor

@eanders-ms eanders-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@tombuMS tombuMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@stevenvergenz stevenvergenz merged commit a1f6cc6 into red Feb 13, 2020
@stevenvergenz stevenvergenz deleted the stvergen/file-reorg branch February 13, 2020 21:16
stevenvergenz added a commit that referenced this pull request Feb 24, 2020
* Start fixing issues with import cleanup

* Finish import changes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants