This repository has been archived by the owner on Jun 10, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 60
Reorganize file structure, consolidate imports #482
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed the adapters are under "internal". We should publish the adapters. WebHost won't be appropriate for everyone. |
I like the new layout! |
Seems reaosnable. Which classes? Just MultipeerAdapter and WebsocketAdapter? In reply to: 584927450 [](ancestors = 584927450) |
Yep those are the only adapters. In reply to: 584936881 [](ancestors = 584936881,584927450) |
eanders-ms
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tombuMS
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
types
folder by topic. The new folder structure looks like this:src/actor
- For the actor classes and all their components. Some component types are complicated enough to justify their own subfolders (i.e.physics
).src/animation
- For the animation types.src/asset
- For the asset classes.src/core
- For system-level classes that still need to be exposed to the user (i.e.Context
).src/math
- For all the math types.src/user
- For the handful of user classes.src/util
- For miscellaneous types that need to be exported (WebHost
,Guid
,log
).src/internal
- For all types that are not exported. This includes all the networking types, adapters, and a raft of utility functions. Note: there are some "internal" types not in this folder (e.g.ActorInternal
), which live in the folder that matches their exposed class. These are still not exposed.src
andsrc/internal
directories instead of from individual files/folders.